Add AWSHTTPClient protocol #602
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adam-fowler
force-pushed
the
aws-http-client
branch
from
5a5847e
to
3d95b70
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## async-nonblocking-fileio #602 +/- ##
============================================================
- Coverage 80.40% 80.39% -0.02%
============================================================
Files 77 78 +1
Lines 6467 6453 -14
============================================================
- Hits 5200 5188 -12
+ Misses 1267 1265 -2 ☔ View full report in Codecov by Sentry. |
0xTim
approved these changes
Mar 30, 2024
| // | ||
| // This source file is part of the Soto for AWS open source project | ||
| // | ||
| // Copyright (c) 2023 the Soto project authors |
There was a problem hiding this comment.
Suggested change
| // Copyright (c) 2023 the Soto project authors | |
| // Copyright (c) 2024 the Soto project authors |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reintroduce the AWSHTTPClient protocol
Eventually this will be used to introduce support for URLSession