Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sendable to AWSShapeOptions #603

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

sidepelican
Copy link
Contributor

In Xcode15.3(now in RC), it shows many warnings of concurrency.

Copy link
Member

@adam-fowler adam-fowler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the Soto Sendable issues are fixed in the 7.0.0-alpha. I wasn't intending on fixing all of them for 6.x.x but there is no harm in merging this though.

Copy link

codecov bot commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.26%. Comparing base (e49b4dc) to head (d17012a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #603      +/-   ##
==========================================
+ Coverage   76.25%   76.26%   +0.01%     
==========================================
  Files          87       87              
  Lines        8557     8557              
==========================================
+ Hits         6525     6526       +1     
+ Misses       2032     2031       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adam-fowler adam-fowler merged commit ca31cbd into soto-project:main Mar 5, 2024
9 checks passed
@sidepelican sidepelican deleted the sendable_option branch March 5, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants