Make all tests use Swift concurrency #679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adam-fowler
force-pushed
the
non-ev-tests
branch
from
d10f4b0
to
319a87a
Compare
0xTim
approved these changes
Jul 5, 2023
Comment on lines
74
to
91
| /* .flatMapErrorThrowing { error in | ||
| switch error { | ||
| case let error as S3ErrorType: | ||
| switch error { | ||
| case .bucketAlreadyOwnedByYou: | ||
| return | ||
| case .bucketAlreadyExists: | ||
| // local stack returns bucketAlreadyExists instead of bucketAlreadyOwnedByYou | ||
| if !TestEnvironment.isUsingLocalstack { | ||
| throw error | ||
| } | ||
| default: | ||
| throw error | ||
| } | ||
| default: | ||
| throw error | ||
| } | ||
| }*/ |
Tests/SotoTests/test.swift
Outdated
There was a problem hiding this comment.
Might be worth renaming the file to something other than just test
|
|
||
| func testS3VirtualAddressing(_ urlString: String, config: AWSServiceConfig = S3ExtensionTests.s3.config) throws -> String { | ||
| /* | ||
| func testSelectObjectContent() throws { |
There was a problem hiding this comment.
Is this to be brought back in a future PR?
adam-fowler
force-pushed
the
non-ev-extensions
branch
from
3c60de3
to
14236b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.