Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exit on Ctrl+Q #898

Merged
merged 1 commit into from
Jan 13, 2025
Merged

Conversation

wl2776
Copy link
Contributor

@wl2776 wl2776 commented Jan 13, 2025

Add hotkey Ctrl-Q for exit command on Linux and Windows.

Currently only MacOS supports exit on Cmd-Q.

@love-linger
Copy link
Collaborator

Cmd+Q is a common hotkey on macOS. The current implementation is only designed to comply with the operating habits of macOS.

On Windows, users can use Alt+F4 to do this, which is also a common hotkey to quit current application.

I don't have Linux device with me now, but I seem to remember that X11 also has a shortcut to close the current window by default

@wl2776
Copy link
Contributor Author

wl2776 commented Jan 13, 2025

I am on Linux (Kubuntu 24.04), the application closes on Alt-F4.

Many other applications also support quit on Ctrl-Q.

@love-linger
Copy link
Collaborator

I really do not want to break the operating system's rule, and I think it is really not necessary to provide multiple hotkeys to do the same thing.

@wl2776
Copy link
Contributor Author

wl2776 commented Jan 13, 2025

In you terminology it is the rule.

image image image image image

@love-linger love-linger self-assigned this Jan 13, 2025
@love-linger love-linger added the enhancement New feature or request label Jan 13, 2025
@love-linger love-linger merged commit 458a1ea into sourcegit-scm:develop Jan 13, 2025
13 checks passed
@wl2776 wl2776 deleted the feature/exit-ctrl-q branch January 13, 2025 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants