Merge pull request #180 from hmazter/php-84-implicit-nullable

Fix deprecation warning for PHP 8.4 implicit nullable parameter
spatie · Dec 16, 2024 · 1dfc9c0 · 1dfc9c0
2 parents ff93066 + c853f16
commit 1dfc9c0
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/src/SimpleExcelReader.php b/src/SimpleExcelReader.php
@@ -138,7 +138,7 @@ public function preserveEmptyRows(): self
         return $this;
     }
 
-    public function trimHeaderRow(string $characters = null): self
+    public function trimHeaderRow(?string $characters = null): self
     {
         $this->trimHeader = true;
         $this->trimHeaderCharacters = $characters;

diff --git a/src/SimpleExcelWriter.php b/src/SimpleExcelWriter.php
@@ -25,7 +25,7 @@ class SimpleExcelWriter
     public static function create(
         string $file,
         string $type = '',
-        callable $configureWriter = null,
+        ?callable $configureWriter = null,
         ?string $delimiter = null,
         ?bool $shouldAddBom = null,
     ): static {
@@ -59,7 +59,7 @@ public static function createWithoutBom(string $file, string $type = ''): static
     public static function streamDownload(
         string $downloadName,
         string $type = '',
-        callable $writerCallback = null,
+        ?callable $writerCallback = null,
         ?string $delimiter = null,
         ?bool $shouldAddBom = null,
     ): static {
@@ -148,7 +148,7 @@ public function setHeaderStyle(Style $style): static
         return $this;
     }
 
-    public function addRow(Row|array $row, Style $style = null): static
+    public function addRow(Row|array $row, ?Style $style = null): static
     {
         if (is_array($row)) {
             if ($this->processHeader && $this->processingFirstRow) {
@@ -166,7 +166,7 @@ public function addRow(Row|array $row, Style $style = null): static
         return $this;
     }
 
-    public function addRows(iterable $rows, Style $style = null): static
+    public function addRows(iterable $rows, ?Style $style = null): static
     {
         foreach ($rows as $row) {
             $this->addRow($row, $style);