New License: InnoSetup #2603
Open
New License: InnoSetup #2603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CCKING87
approved these changes
Nov 3, 2024
swinslow
reviewed
Nov 11, 2024
src/InnoSetup.xml
Outdated
| </crossRefs> | ||
| <text> | ||
| <titleText> | ||
| Inno Setup License ================== |
There was a problem hiding this comment.
I'd suggest adding a <br /> here for a line break.
src/InnoSetup.xml
Outdated
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <SPDXLicenseCollection xmlns="http://www.spdx.org/license"> | ||
| <license isOsiApproved="false" licenseId="InnoSetup" | ||
| name="InnoSetup license" listVersionAdded="3.26"> |
There was a problem hiding this comment.
Would suggest "Inno Setup License" -- three words rather than two to reflect the actual license's title, and capital "L" also since we usually capitalize "License" as last word for licenses' full names on the list.
| <titleText> | ||
| Inno Setup License ================== | ||
| </titleText> | ||
| <p> |
There was a problem hiding this comment.
Lines 12-19 should probably be wrapped in a <copyrightText> tag.
Signed-off-by: Steve Winslow <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2550
Signed-off-by: Jilayne Lovejoy