Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix path errors while analyzing packages referencing ${java.home} #121

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

ftake
Copy link

@ftake ftake commented Apr 19, 2024

Some packages (e.g., Javassist) refere ${java.home} in of their dependencies. This commit add "java.home" to the passthrough properties list and prevent maven from complaining such paths are not absolute.

Caused by: org.apache.maven.model.building.ModelBuildingException: 1 problem was encountered while building the effective model for org.javassist:javassist:3.29.2-GA
[ERROR] 'dependencies.dependency.systemPath' for com.sun:tools:jar must specify an absolute path but is ${java.home}/lib/jrt-fs.jar @ 

	at org.apache.maven.model.building.DefaultModelProblemCollector.newModelBuildingException(DefaultModelProblemCollector.java:176)
	at org.apache.maven.model.building.DefaultModelBuilder.build(DefaultModelBuilder.java:508)
	at org.apache.maven.model.building.DefaultModelBuilder.build(DefaultModelBuilder.java:410)
	at org.apache.maven.model.building.DefaultModelBuilder.build(DefaultModelBuilder.java:243)
	at org.spdx.sbom.gradle.maven.PomResolver.resolveEffectivePom(PomResolver.java:207)
	... 93 more

Some packages (e.g., Javassist) refere ${java.home} in <systemPath> of their dependencies. This commit add "java.home" to the passthrough properties list and prevent maven from complaining such paths are not absolute.

Signed-off-by: Fuminobu TAKEYAMA <[email protected]>
@loosebazooka loosebazooka merged commit 10ce370 into spdx:main Apr 22, 2024
1 check passed
@loosebazooka
Copy link
Collaborator

Thanks for the contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants