Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Qt Introduction #10

Merged
merged 11 commits into from
Feb 10, 2025
Merged

Conversation

yeimiyaz
Copy link
Contributor

@yeimiyaz yeimiyaz commented Dec 20, 2024

Pull Request

Pull Request Checklist

  • Read and followed this repo's Contributing Guidelines
  • Based your PR on the latest version of the correct branch
  • Checked your code and writing carefully
  • Described your changes and the motivation for them below

Description of Changes

This pull request includes the improvement of the Qt introduction page.
I have enriched the descriptions of the sections taking into account the official Qt documentation.

After the changes, I was not sure about the following text description:

Dialog section
"Dialogs are commonly used for functions that do not fit into the main interface."
"Qt provides some special dialogs for the most common use-cases as file Open/Save, font selection, error messages, color choosing, printing, among others."

Signals & Slots section
"Functions or methods could be used as slots, by connecting a signal to them."
"If a signal sends data, the receiver callable will also receive it."

Please validate them.
Thanks

@yeimiyaz yeimiyaz requested a review from CAM-Gerlach December 20, 2024 22:38
@yeimiyaz yeimiyaz self-assigned this Dec 20, 2024
Copy link

netlify bot commented Dec 20, 2024

Deploy Preview for spyder-api-docs-preview ready!

Name Link
🔨 Latest commit 8c94669
🔍 Latest deploy log https://app.netlify.com/sites/spyder-api-docs-preview/deploys/67a519ec082bb40008568f16
😎 Deploy Preview https://deploy-preview-10--spyder-api-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@CAM-Gerlach CAM-Gerlach changed the title Improvement of the Qt Introduction Improve Qt Introduction Dec 24, 2024
@CAM-Gerlach CAM-Gerlach added the enhancement New feature or request label Dec 24, 2024
@CAM-Gerlach CAM-Gerlach self-requested a review February 6, 2025 20:27
@CAM-Gerlach CAM-Gerlach marked this pull request as ready for review February 6, 2025 20:27
Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After our agreed changes, LGTM!

Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yeimiyaz and @CAM-Gerlach for your work on this!

@CAM-Gerlach CAM-Gerlach merged commit 70168c9 into spyder-ide:master Feb 10, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants