Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Replace set with list when searching for installed program #23327

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

mrclary
Copy link
Contributor

@mrclary mrclary commented Dec 20, 2024

set does not guarantee order, so could be non-deterministic. Also, it is desirable for the priority to be extra_paths, conda, pyenv, then system paths

Part of #23061

set did not guarantee order, so could be non-deterministic.
Also, it is desirable for the priority to be extra_paths, conda, pyenv, then system paths
@mrclary mrclary self-assigned this Dec 20, 2024
@mrclary mrclary marked this pull request as ready for review December 20, 2024 20:29
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @mrclary!

@ccordoba12 ccordoba12 added this to the v6.0.4 milestone Jan 3, 2025
@ccordoba12 ccordoba12 merged commit 5b06eb5 into spyder-ide:master Jan 3, 2025
17 checks passed
@ccordoba12
Copy link
Member

@meeseeksdev please backport to 6.x

meeseeksmachine pushed a commit to meeseeksmachine/spyder that referenced this pull request Jan 3, 2025
ccordoba12 pushed a commit that referenced this pull request Jan 3, 2025
@mrclary mrclary deleted the issue-23061-find-program branch January 14, 2025 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants