fix(sqlite): allow using fts5 table name in the where clause

sqlc-dev · Jul 22, 2024 · d2e447d · d2e447d
1 parent b78e322
commit d2e447d
Show file tree

Hide file tree

Showing 4 changed files with 93 additions and 10 deletions.
diff --git a/internal/endtoend/testdata/virtual_table/sqlite/go/models.go b/internal/endtoend/testdata/virtual_table/sqlite/go/models.go
diff --git a/internal/endtoend/testdata/virtual_table/sqlite/go/query.sql.go b/internal/endtoend/testdata/virtual_table/sqlite/go/query.sql.go
diff --git a/internal/endtoend/testdata/virtual_table/sqlite/query.sql b/internal/endtoend/testdata/virtual_table/sqlite/query.sql
@@ -14,6 +14,14 @@ WHERE b = ?;
 SELECT c FROM tbl_ft
 WHERE b = ?;
 
+-- name: SelectAllColsTblFtEqualByTableName :many
+SELECT * FROM tbl_ft
+WHERE tbl_ft = ?;
+
+-- name: SelectAllColsTblFtMatchByTableName :many
+SELECT * FROM tbl_ft
+WHERE tbl_ft MATCH ?;
+
 -- name: SelectHightlighFunc :many
 SELECT highlight(tbl_ft, 0, '<b>', '</b>') FROM tbl_ft
 WHERE b MATCH ?;

diff --git a/internal/engine/sqlite/convert.go b/internal/engine/sqlite/convert.go
@@ -168,6 +168,12 @@ func (c *cc) convertCreate_virtual_table_fts5(n *parser.Create_virtual_table_stm
 		}
 	}
 
+	stmt.Cols = append(stmt.Cols, &ast.ColumnDef{
+		Colname: identifier(stmt.Name.Name),
+		IsNotNull: true,
+		TypeName: &ast.TypeName{Name: "text"},
+	})
+
 	return stmt
 }