Prototype support for handling absence #1412
Draft
+349
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(edit: see following comments, this was generalized away from just Optional)
This is a prototype of what
Optional
support would look like. This implements it in two parts:OptionalJsonAdapter
+ associated factory. This essentially works by associating nulls withOptional.absent()
and used for properties that are either present or explicitlynull
.ClassJsonAdapter
andKotlinJsonAdapter
for supporting defaulting absent values toOptional.empty()
.Open questions:
a.
Optional<String>?
b. Do we support this in code gen too?
j.u.Optional
or do we want to do something more generic (to support Guava, KOptional, etc)? How would that look if so?JsonAdapter.ifAbsent()
or separateAbsenceHandler
interface?