Dashboard UI for adding users to a team #334
Conversation
fomalhautb
commented
Nov 8, 2024
•
fomalhautb
commented
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| toast({ title: 'User added to team', variant: 'success' }); | ||
| } catch (error) { | ||
| if (error instanceof KnownErrors.TeamMembershipAlreadyExists) { | ||
| toast({ title: 'User already a member of this team', variant: 'destructive' }); |
There was a problem hiding this comment.
IMO toasts are for things that are not crucial to the user flow (eg. "everything went as planned") — this should be an alert
There was a problem hiding this comment.
Actually, I think it is better to show an "added" button (see the updated image in the PR description). It will be a bit more annoying when we later paginate the team-member tables as we will need to do it on the server side, but we can worry about that later
There was a problem hiding this comment.
What happens if the user was not added successfully because they're already in the team?
There was a problem hiding this comment.
Ah nvm I get what you mean now
There was a problem hiding this comment.
The toast is not necessary though — from a user perspective, "the user has been added" and "the user has already been on the team" is equivalent
