Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement empty state for tables #232

Merged
merged 15 commits into from
Jan 30, 2025
Merged

feat: implement empty state for tables #232

merged 15 commits into from
Jan 30, 2025

Conversation

kantord
Copy link
Member

@kantord kantord commented Jan 30, 2025

fixes #160

Notes

  • I took some liberty with the copy because the copy in the design refers to "interactions", not alerts. We have not implemented this change yet, so to keep it logical and consistent with the current behavior, I rewrote it slightly
  • In order to detect if we need to show the setup instructions in the empty table, I use the following heuristic: if the user has multiple workspaces, we will show a message that explains how workspaces work, instead of explaining the basic setup. This makes sense imo, because a user having multiple workspaces is likely to be confused about how workspaces work

Screenshots

Screenshot_select-area_20250130150633

Screenshot_select-area_20250130155830

@kantord kantord changed the title implement empty state for tables feat: implement empty state for tables Jan 30, 2025
@coveralls
Copy link
Collaborator

coveralls commented Jan 30, 2025

Pull Request Test Coverage Report for Build 13054952285

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 73.338%

Totals Coverage Status
Change from base Build 13054225475: 0.2%
Covered Lines: 770
Relevant Lines: 985

💛 - Coveralls

@kantord kantord marked this pull request as ready for review January 30, 2025 14:58
@kantord kantord requested review from peppescg and alex-mcgovern and removed request for peppescg January 30, 2025 14:58
@kantord kantord merged commit e39dbc3 into main Jan 30, 2025
9 checks passed
@kantord kantord deleted the empty-state-for-tables branch January 30, 2025 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nit: table empty state
3 participants