Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(alerts): tabs for filtering table #234

Merged
merged 7 commits into from
Jan 31, 2025

Conversation

alex-mcgovern
Copy link
Collaborator

  • adds tabs to toggle between different types of alerts
  • moves filtering & pagination logic into searchParams (only 2 usages of zustand left 🙌🏻)
Screen.Recording.2025-01-30.at.3.16.05.PM.mov

@coveralls
Copy link
Collaborator

coveralls commented Jan 30, 2025

Pull Request Test Coverage Report for Build 13069930661

Details

  • 22 of 23 (95.65%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.5%) to 73.779%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/features/alerts/components/table-alerts.tsx 1 2 50.0%
Totals Coverage Status
Change from base Build 13069922467: 0.5%
Covered Lines: 784
Relevant Lines: 996

💛 - Coveralls

@peppescg
Copy link
Collaborator

There is something weird looking to the video, the total number of alerts are 22, but malicious + secrets are 38 🤔

@alex-mcgovern alex-mcgovern merged commit 2765917 into main Jan 31, 2025
8 checks passed
@alex-mcgovern alex-mcgovern deleted the feat/alerts/tabs-for-table branch January 31, 2025 09:37
@jtenniswood
Copy link

What happens when you search within a filtered view?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants