Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make setup menu in header less confusing #81

Merged
merged 2 commits into from
Jan 15, 2025

Conversation

kantord
Copy link
Member

@kantord kantord commented Jan 15, 2025

Before

Screenshot_select-area_20250115160416

After

Screenshot_select-area_20250115155258

Copy link

Minder Vulnerability Report ✅

Minder analyzed this PR and found it does not add any new vulnerable dependencies.

Vulnerability scan of e4840e68:

  • 🐞 vulnerable packages: 0
  • 🛠 fixes available for: 0

Copy link

@stacklok-cloud-staging stacklok-cloud-staging bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dependency Information

Minder analyzed the dependencies introduced in this pull request and detected that some dependencies do not meet your security profile.

📦 Dependency: prettier

Trusty Score: 0

Scoring details
Component Score
Provenance unknown
Alternatives
Package Score Description
eslint 0
standard 0
xo 0

@kantord kantord changed the title Fix setup menu in header feat: make setup menu in header less confusing Jan 15, 2025
@kantord kantord force-pushed the fix-setup-menu-in-header branch from e4840e6 to fdf9102 Compare January 15, 2025 15:08
@kantord kantord self-assigned this Jan 15, 2025
peppescg
peppescg previously approved these changes Jan 15, 2025
commit 55b0745
Author: Daniel Kantor <[email protected]>
Date:   Wed Jan 15 15:01:35 2025 +0100

    chore: add prettier

commit b610317
Author: Daniel Kantor <[email protected]>
Date:   Wed Jan 15 14:50:49 2025 +0100

    refactor: extract <DropdownMenuItem />

commit d3513aa
Author: Daniel Kantor <[email protected]>
Date:   Wed Jan 15 14:48:06 2025 +0100

    refactor: extract <DropdownMenu />

commit 9eb2021
Author: Daniel Kantor <[email protected]>
Date:   Wed Jan 15 14:44:34 2025 +0100

    refactor: extract <HeaderMenuItem />
@coveralls
Copy link
Collaborator

coveralls commented Jan 15, 2025

Pull Request Test Coverage Report for Build 12793000248

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 69.536%

Totals Coverage Status
Change from base Build 12791989251: 0.0%
Covered Lines: 421
Relevant Lines: 526

💛 - Coveralls

@kantord kantord enabled auto-merge (squash) January 15, 2025 16:44
@kantord kantord merged commit ae42046 into main Jan 15, 2025
7 checks passed
@kantord kantord deleted the fix-setup-menu-in-header branch January 15, 2025 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants