Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Onboarding Setup #956

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

feat: Onboarding Setup #956

wants to merge 17 commits into from

Conversation

dorelljames
Copy link
Contributor

Fixes issue #850

Copy link

what-the-diff bot commented Mar 7, 2024

PR Summary

  • Improved Terminal Output via Bootstrap File
    The bootstrap file has been updated to show the current project directory path. This will make it easier to keep track of where you are when working on the project.

  • Automatic Installation of Project Dependencies
    A new line of code has been added to the bootstrap file. Now, it uses a tool called 'bun' to automatically install the project's dependencies. You won't have to manually install each one, thus saving time and streamlining the setup process.

  • Updated pkgx-install Script
    The entire script in the pkgx-install file has been replaced with a new, more efficient script fetched from pkgx.sh using curl. This change updates the package installation process thus making the overall system more efficient.

@dorelljames dorelljames marked this pull request as draft March 7, 2024 01:17
@dorelljames dorelljames changed the title Feat: Onboarding Setup [WIP] Feat: Onboarding Setup Mar 7, 2024
@dorelljames dorelljames changed the title [WIP] Feat: Onboarding Setup feat: Onboarding Setup Apr 4, 2024
@dorelljames dorelljames marked this pull request as ready for review April 4, 2024 00:45
@dorelljames
Copy link
Contributor Author

This should be good to go unless there are still files that I've missed.

@chrisbbreuer
Copy link
Member

getting there 🔥

modules: () =>
p.multiselect({
message: 'Select additional modules.',
initialValues: ['prettier', 'eslint'],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unsure why prettier is here. We don't use it, and actively suggest people not to use it in combination with Stacks formatting 👍

Comment on lines +128 to +134
const configToPackageMap: Readonly<{ [packageName: string]: string[] }> = {
redis: ['cache.ts', 'session.ts'], // Example: both cache.ts and session.ts need redis

// sqlite: ['sample.ts'], // Example: sqlite will be removed when this is uncommented since sample.ts does not exist

// You can add other mappings here
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to finish this

Comment on lines +1 to +17
{
"name": "stacks-onboarding",
"version": "0.0.1",
"description": "",
"main": "index.js",
"scripts": {
"test": "echo \"Error: no test specified\" && exit 1"
},
"keywords": [],
"author": "",
"license": "ISC",
"dependencies": {
"@clack/core": "^0.3.4",
"@clack/prompts": "^0.7.0",
"picocolors": "^1.0.0"
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't be here and extracted to core packages, placed where appropriate, like the cli package.

We may already may require these deps elsewhere too

Comment on lines +1 to +13
{
"compilerOptions": {
"noEmit": true,
"module": "ESNext",
"target": "ESNext",
"moduleResolution": "node",
"strict": true,
"esModuleInterop": true,
"forceConsistentCasingInFileNames": true,
"skipLibCheck": true
},
"include": ["packages"]
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also isn't needed then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants