-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Onboarding Setup #956
base: main
Are you sure you want to change the base?
Conversation
PR Summary
|
4a90baf
to
0996582
Compare
This should be good to go unless there are still files that I've missed. |
getting there 🔥 |
4578293
to
d9c4e87
Compare
7599333
to
531c442
Compare
modules: () => | ||
p.multiselect({ | ||
message: 'Select additional modules.', | ||
initialValues: ['prettier', 'eslint'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unsure why prettier is here. We don't use it, and actively suggest people not to use it in combination with Stacks formatting 👍
const configToPackageMap: Readonly<{ [packageName: string]: string[] }> = { | ||
redis: ['cache.ts', 'session.ts'], // Example: both cache.ts and session.ts need redis | ||
|
||
// sqlite: ['sample.ts'], // Example: sqlite will be removed when this is uncommented since sample.ts does not exist | ||
|
||
// You can add other mappings here | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to finish this
{ | ||
"name": "stacks-onboarding", | ||
"version": "0.0.1", | ||
"description": "", | ||
"main": "index.js", | ||
"scripts": { | ||
"test": "echo \"Error: no test specified\" && exit 1" | ||
}, | ||
"keywords": [], | ||
"author": "", | ||
"license": "ISC", | ||
"dependencies": { | ||
"@clack/core": "^0.3.4", | ||
"@clack/prompts": "^0.7.0", | ||
"picocolors": "^1.0.0" | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This shouldn't be here and extracted to core packages, placed where appropriate, like the cli package.
We may already may require these deps elsewhere too
{ | ||
"compilerOptions": { | ||
"noEmit": true, | ||
"module": "ESNext", | ||
"target": "ESNext", | ||
"moduleResolution": "node", | ||
"strict": true, | ||
"esModuleInterop": true, | ||
"forceConsistentCasingInFileNames": true, | ||
"skipLibCheck": true | ||
}, | ||
"include": ["packages"] | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This also isn't needed then
Fixes issue #850