Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dark-L vowels to EnXSampaPhonemizer.cs #1193

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

HitCoder9768
Copy link
Contributor

for reclists such as my own using phonemes such as O5 for "cold"

for reclists such as my own using phonemes such as `O5` for "cold"
@oxygen-dioxide
Copy link
Contributor

The GitHub action tests failed. Please ensure that the unit tests passed. You can use dotnet test command to run the tests locally.
If your code changes the behaviour of the phonemizer, also change them in the unit tests.

@lottev1991
Copy link
Contributor

(Apologies, I sent this on Discord too but it's kinda important) I also noticed that you've defined the Ol vowel twice; it was already defined, and defining it twice will break the code and the phonemizer will not work (see oxygen's message; I think this is why the tests might be failing). Please fix that, thanks in advance.

@stakira
Copy link
Owner

stakira commented Sep 1, 2024

Sorry, it has been a while and there are conflicts. Could you resolve it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants