Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaning up unused code in meta #2998

Merged
merged 8 commits into from
Jan 18, 2024
Merged

Cleaning up unused code in meta #2998

merged 8 commits into from
Jan 18, 2024

Conversation

syclik
Copy link
Member

@syclik syclik commented Jan 7, 2024

Summary

Removes unused meta traits from code.

These are template metaprograms not used anywhere in the codebase. Some of the functionality has been replaced with newer require_* traits.

runTests.py has been updated for the --changed tests. Removal of tests results in the test being called. This was fixed using --diff-filter=d which excludes deleted files.

Tests

No new tests. There is no additional behavior.

Side Effects

External calls to these traits will break. These are not used within Stan and Math (anymore) and can be removed safely without affecting the Stan ecosystem.

Release notes

Removing unused template metaprograms.

Checklist

  • Copyright holder: Daniel Lee

    The copyright holder is typically you or your assignee, such as a university or company. By submitting this pull request, the copyright holder is agreeing to the license the submitted work under the following licenses:
    - Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
    - Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)

  • the basic tests are passing

    • unit tests pass (to run, use: ./runTests.py test/unit)
    • header checks pass, (make test-headers)
    • dependencies checks pass, (make test-math-dependencies)
    • docs build, (make doxygen)
    • code passes the built in C++ standards checks (make cpplint)
  • the code is written in idiomatic C++ and changes are documented in the doxygen

  • the new changes are tested

@syclik syclik force-pushed the feature/cleanup-meta branch from 26a1fcc to 853f024 Compare January 8, 2024 00:37
@syclik syclik force-pushed the feature/cleanup-meta branch from 853f024 to ec4cc9c Compare January 11, 2024 14:08
Copy link
Member

@WardBrian WardBrian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanups, and thanks for the patch to runTests.

@syclik syclik merged commit c8abe2a into develop Jan 18, 2024
8 checks passed
@syclik syclik deleted the feature/cleanup-meta branch January 18, 2024 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants