Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test model and gradients evaluate at initial condition (Issue #3034) #3035

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

bbbales2
Copy link
Member

Submission Checklist

  • Run unit tests: ./runTests.py src/test/unit
  • Run cpplint: make cpplint
  • Declare copyright holder and open-source license: see below

Summary

Fix for #3034

The 100 tries to initialize the model currently tries to evaluate log_prob without gradients and then the next block of code tries to benchmark the gradients. This was failing.

Instead in this pull we try the 100 tries evaluating gradients as well (since we'll need them eventually).

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company): Columbia University

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants