Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev to main update #212

Merged
merged 6 commits into from
Oct 31, 2024
Merged

dev to main update #212

merged 6 commits into from
Oct 31, 2024

Conversation

carmichaelong
Copy link
Contributor

Includes update for ipad pro intrinsics, and updating database duration under more cases (especially when an exception is thrown during processTrial().

Tests:

  • Ensured that ipad pro threw an error about intrinsics after calibration on production. Then on dev, took a full session with walking and hops that looked smooth.
  • For duration issue, reprocessed an old trial on dev that threw an error. It still threw an error but also updated the database with the duration.

AlbertoCasasOrtiz
AlbertoCasasOrtiz approved these changes Oct 31, 2024
View reviewed changes
Copy link
Collaborator

@AlbertoCasasOrtiz AlbertoCasasOrtiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I think the approach you followed to test it sounds reasonable.

@carmichaelong carmichaelong merged commit 48c1374 into main Oct 31, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlbertoCasasOrtiz AlbertoCasasOrtiz AlbertoCasasOrtiz approved these changes

@antoinefalisse antoinefalisse Awaiting requested review from antoinefalisse

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@carmichaelong @AlbertoCasasOrtiz @mattpetrucci