main <- dev #231
Open
main <- dev #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add mapping for genders in metadata
Add retry mechanism to many database requests
Intercepting error of human detection pose not detected in hrnet.
Lying checkerboard
…Retry error handling
Dev: New deployment for new Server
There was a problem hiding this comment.
these changes look safe and pretty well tested from before.
one question i have is probably more for @antoinefalisse: the change to checkerboard means that there are some strings for checkerBoardMount that will throw now when they didn't before (backWall_largeCB, backWall_walking, ground_jumps, ground_gaits. i assume this doesn't affect any new (or recent) trials. do you have any insight for what (older) trials might have issues with this? or was it all just used by you all internally from awhile ago?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many changes here related to deploying so we should be extra careful.
This should be deployed with: stanfordnmbl/opencap-viewer#420