Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SSH key support #15

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

natrem
Copy link

@natrem natrem commented Nov 5, 2018

  • Allow testing with an identity (SSH key)
  • Add a private/public key for unit tests

@natrem
Copy link
Author

natrem commented Nov 5, 2018

There are issues on Travis that I don't manage to reproduce locally (windows desktop so it might be related).
I'll add some commits to provide more logs during tests; please do not merge for now

@natrem natrem changed the title Add SSH key support [DO NOT MERGE] Add SSH key support Nov 5, 2018
@natrem
Copy link
Author

natrem commented Nov 5, 2018

Note: from the build logs it seems like a permission issue on Travis:

invalid file=/home/travis/build/stefanbirkner/fake-sftp-server-rule/target/test-classes/keys/dummy_key.pub permissions: Permissions violation (GROUP_READ)

After investigation the authorized_keys is checked on access rights but we can disable this.

@natrem natrem force-pushed the support-ssh-key-connection branch from acbca1d to 1164c03 Compare November 5, 2018 15:22
@natrem natrem changed the title [DO NOT MERGE] Add SSH key support Add SSH key support Nov 5, 2018
@natrem natrem mentioned this pull request Nov 13, 2018
@johanhaleby
Copy link

I'd really like to see this merged, what's the status? Anything I can do to help?

sz332 added a commit to sz332/fake-sftp-server-rule that referenced this pull request Mar 6, 2019
@dtrouillet
Copy link

Hello,

I'm very insterested by this support.
Why is not merged ?

Regard

@daniele-xp
Copy link

I'm interested too .. @stefanbirkner could you merge it?

@thenatog
Copy link

Also think this would be great to see merged.

@sourcecodeas
Copy link

What's the status of this PR @stefanbirkner? Why is it not merged or updated 2 years after the last update? We are not able to test integrations which are dependant on a this.

@sourcecodeas
Copy link

What's the status of this PR @stefanbirkner? Why is it not merged or updated 2 years after the last update? We are not able to test integrations which are dependant on a this.

Ping @stefanbirkner

@stefanbirkner
Copy link
Owner

I remember that there is a corner case why I didn't merge it. I start to improve Fake SFTP Server Rule next week.

@stefanbirkner stefanbirkner force-pushed the master branch 2 times, most recently from a2cd3d8 to 318473c Compare February 19, 2021 22:29
@achimgrimm
Copy link

Hi @stefanbirkner,
can you please give us an update?

@stefanbirkner
Copy link
Owner

I started to look at the issue again. All memory is lost.

@stefanbirkner
Copy link
Owner

I'm still working on it. I found that it is not as easy as I thought.

@marklee230
Copy link

Hi @stefanbirkner, have you made any progress with merging this pr?

@stefanbirkner
Copy link
Owner

I'm working on a different API for SSH access but there are some problems. I cannot promise any date for when this will be done because my time is limited. If anyone wants to fork this project and add SSH support: feel free to do it and add the Maven coordinates in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants