Update outdated code. #759
Conversation
overcat
force-pushed
the
update-outdated-code
branch
from
2d431ac
to
29752d3
Compare
|
Preview is available here: |
1 similar comment
|
Preview is available here: |
overcat
force-pushed
the
update-outdated-code
branch
from
29752d3
to
4c88ae0
Compare
|
Preview is available here: |
|
@overcat This is an incredibly helpful contribution!!! We truly can't thank you enough for this! Are the changes ready to be merged, or is there still some work (or other updates) you have left? I'm happy to approve and merge this, just want to make sure I don't do it while you're still in the middle of it 👍🏻 Thanks again! |
|
Hi @ElliotFriend, this PR has been completed, and all the code has been tested by me. But there is one part that I did not modify, which is that the increment contract has changed. Now the COUNTER in the increment contract is stored in the instance, which does not meet the requirements of the example very well. So I made some modifications to this contract, I store COUNTER in Persistent. All these examples are based on this point. See https://github.com/stellar/soroban-examples/blob/main/increment/src/lib.rs#L21 |
|
Yeah, I think I came across something that threw me off recently with Thanks again! Big help here! |
Here are some Python and JavaScript codes that have become outdated and cannot run smoothly under the latest version of SDK. This PR updates them.