-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend SigningCallback
form to allow returning an object
#783
base: master
Are you sure you want to change the base?
Conversation
Size Change: +2.75 kB (+0.08%) Total Size: 3.26 MB
|
Co-authored-by: Jun Luo <[email protected]>
Co-authored-by: Jun Luo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I don't feel like I have much to add here. What I'm working on doesn't involve signing with G-addresses much anymore so I wouldn't be using this. If I do sign with a G-address the entire auth flow is custom as per whatever the __check_auth |
Closes #780 per discussion in #772 (comment):
authorizeEntry
can now take a callback that returns an object specifying the signer of the signature so that it isn't implied that it's the address in the entry. Namely, it can return