BREAKING CHANGE: drop creator support (jsdom#101)

stevedorries · Nov 2, 2017 · 0ecc486 · 0ecc486
1 parent 4f1aab4
commit 0ecc486
Show file tree

Hide file tree

Showing 33 changed files with 36 additions and 103 deletions.
diff --git a/README.md b/README.md
@@ -358,7 +358,6 @@ An operation looks like this:
   "type": "operation",
   "getter": false,
   "setter": false,
-  "creator": false,
   "deleter": false,
   "static": false,
   "stringifier": false,
@@ -392,7 +391,6 @@ The fields are as follows:
 * `type`: Always "operation".
 * `getter`: True if a getter operation.
 * `setter`: True if a setter operation.
-* `creator`: True if a creator operation.
 * `deleter`: True if a deleter operation.
 * `static`: True if a static operation.
 * `stringifier`: True if a stringifier operation.
@@ -471,7 +469,6 @@ Iterator members look like this
   "type": "iterator",
   "getter": false,
   "setter": false,
-  "creator": false,
   "deleter": false,
   "static": false,
   "stringifier": false,

diff --git a/lib/webidl2.js b/lib/webidl2.js
@@ -573,7 +573,6 @@
         type: "operation",
         getter: false,
         setter: false,
-        creator: false,
         deleter: false,
         "static": false,
         stringifier: false
@@ -582,11 +581,10 @@
         all_ws();
         if (consume(ID, "getter")) ret.getter = true;
         else if (consume(ID, "setter")) ret.setter = true;
-        else if (consume(ID, "creator")) ret.creator = true;
         else if (consume(ID, "deleter")) ret.deleter = true;
         else break;
       }
-      if (ret.getter || ret.setter || ret.creator || ret.deleter) {
+      if (ret.getter || ret.setter || ret.deleter) {
         all_ws();
         ret.idlType = return_type();
         operation_rest(ret, store);
@@ -800,7 +798,6 @@
         type: "operation",
         getter: false,
         setter: false,
-        creator: false,
         deleter: false,
         "static": false,
         stringifier: false

diff --git a/test/invalid/idl/setter-creator.widl b/test/invalid/idl/setter-creator.widl
@@ -0,0 +1,4 @@
+// Extracted from http://dev.w3.org/2006/webapi/WebIDL/ on 2011-05-06
+interface OrderedMap {
+  setter creator void set(DOMString name, any value);
+};
diff --git a/test/invalid/json/setter-creator.json b/test/invalid/json/setter-creator.json
@@ -0,0 +1,4 @@
+{
+    "message": "Invalid operation",
+    "line": 3
+}
diff --git a/test/syntax/idl/indexed-properties.widl b/test/syntax/idl/indexed-properties.widl
@@ -7,6 +7,6 @@ interface OrderedMap {
   deleter void removeByIndex(unsigned long index);
 
   getter any get(DOMString name);
-  setter creator void set(DOMString name, any value);
+  setter void set(DOMString name, any value);
   deleter void remove(DOMString name);
-};
+};
diff --git a/test/syntax/json/allowany.json b/test/syntax/json/allowany.json
@@ -8,7 +8,6 @@
                 "type": "operation",
                 "getter": false,
                 "setter": false,
-                "creator": false,
                 "deleter": false,
                 "static": false,
                 "stringifier": false,
@@ -27,7 +26,6 @@
                 "type": "operation",
                 "getter": false,
                 "setter": false,
-                "creator": false,
                 "deleter": false,
                 "static": false,
                 "stringifier": false,
@@ -60,7 +58,6 @@
                 "type": "operation",
                 "getter": false,
                 "setter": false,
-                "creator": false,
                 "deleter": false,
                 "static": false,
                 "stringifier": false,
@@ -99,4 +96,4 @@
         "inheritance": null,
         "extAttrs": []
     }
-]
+]
diff --git a/test/syntax/json/callback.json b/test/syntax/json/callback.json
@@ -35,7 +35,6 @@
                 "type": "operation",
                 "getter": false,
                 "setter": false,
-                "creator": false,
                 "deleter": false,
                 "static": false,
                 "stringifier": false,
@@ -108,4 +107,4 @@
         ],
         "extAttrs": []
     }
-]
+]
diff --git a/test/syntax/json/enum.json b/test/syntax/json/enum.json
@@ -50,7 +50,6 @@
                 "type": "operation",
                 "getter": false,
                 "setter": false,
-                "creator": false,
                 "deleter": false,
                 "static": false,
                 "stringifier": false,
@@ -106,4 +105,4 @@
         ],
         "extAttrs": []
     }
-]
+]
diff --git a/test/syntax/json/equivalent-decl.json b/test/syntax/json/equivalent-decl.json
@@ -24,7 +24,6 @@
                 "type": "operation",
                 "getter": true,
                 "setter": false,
-                "creator": false,
                 "deleter": false,
                 "static": false,
                 "stringifier": false,
@@ -57,7 +56,6 @@
                 "type": "operation",
                 "getter": false,
                 "setter": true,
-                "creator": false,
                 "deleter": false,
                 "static": false,
                 "stringifier": false,
@@ -128,7 +126,6 @@
                 "type": "operation",
                 "getter": false,
                 "setter": false,
-                "creator": false,
                 "deleter": false,
                 "static": false,
                 "stringifier": false,
@@ -161,7 +158,6 @@
                 "type": "operation",
                 "getter": false,
                 "setter": false,
-                "creator": false,
                 "deleter": false,
                 "static": false,
                 "stringifier": false,
@@ -207,7 +203,6 @@
                 "type": "operation",
                 "getter": true,
                 "setter": false,
-                "creator": false,
                 "deleter": false,
                 "static": false,
                 "stringifier": false,
@@ -240,7 +235,6 @@
                 "type": "operation",
                 "getter": false,
                 "setter": true,
-                "creator": false,
                 "deleter": false,
                 "static": false,
                 "stringifier": false,
@@ -286,4 +280,4 @@
         "inheritance": null,
         "extAttrs": []
     }
-]
+]
diff --git a/test/syntax/json/generic.json b/test/syntax/json/generic.json
@@ -8,7 +8,6 @@
                 "type": "operation",
                 "getter": false,
                 "setter": false,
-                "creator": false,
                 "deleter": false,
                 "static": false,
                 "stringifier": false,
@@ -76,7 +75,6 @@
                 "type": "operation",
                 "getter": false,
                 "setter": false,
-                "creator": false,
                 "deleter": false,
                 "static": false,
                 "stringifier": false,
@@ -101,7 +99,6 @@
                 "type": "operation",
                 "getter": false,
                 "setter": false,
-                "creator": false,
                 "deleter": false,
                 "static": false,
                 "stringifier": false,
@@ -135,7 +132,6 @@
                 "type": "operation",
                 "getter": false,
                 "setter": false,
-                "creator": false,
                 "deleter": false,
                 "static": false,
                 "stringifier": false,
@@ -160,4 +156,4 @@
         "inheritance": "Event",
         "extAttrs": []
     }
-]
+]
diff --git a/test/syntax/json/getter-setter.json b/test/syntax/json/getter-setter.json
@@ -24,7 +24,6 @@
                 "type": "operation",
                 "getter": true,
                 "setter": false,
-                "creator": false,
                 "deleter": false,
                 "static": false,
                 "stringifier": false,
@@ -57,7 +56,6 @@
                 "type": "operation",
                 "getter": false,
                 "setter": true,
-                "creator": false,
                 "deleter": false,
                 "static": false,
                 "stringifier": false,
@@ -103,4 +101,4 @@
         "inheritance": null,
         "extAttrs": []
     }
-]
+]
diff --git a/test/syntax/json/identifier-qualified-names.json b/test/syntax/json/identifier-qualified-names.json
@@ -20,7 +20,6 @@
                 "type": "operation",
                 "getter": false,
                 "setter": false,
-                "creator": false,
                 "deleter": false,
                 "static": false,
                 "stringifier": false,
@@ -53,7 +52,6 @@
                 "type": "operation",
                 "getter": true,
                 "setter": false,
-                "creator": false,
                 "deleter": false,
                 "static": false,
                 "stringifier": false,
@@ -136,7 +134,6 @@
                 "type": "operation",
                 "getter": false,
                 "setter": false,
-                "creator": false,
                 "deleter": false,
                 "static": false,
                 "stringifier": false,

diff --git a/test/syntax/json/implements.json b/test/syntax/json/implements.json
@@ -33,7 +33,6 @@
                 "type": "operation",
                 "getter": false,
                 "setter": false,
-                "creator": false,
                 "deleter": false,
                 "static": false,
                 "stringifier": false,
@@ -98,4 +97,4 @@
         "implements": "EventTarget",
         "extAttrs": []
     }
-]
+]
diff --git a/test/syntax/json/indexed-properties.json b/test/syntax/json/indexed-properties.json
@@ -24,7 +24,6 @@
                 "type": "operation",
                 "getter": true,
                 "setter": false,
-                "creator": false,
                 "deleter": false,
                 "static": false,
                 "stringifier": false,
@@ -57,7 +56,6 @@
                 "type": "operation",
                 "getter": false,
                 "setter": true,
-                "creator": false,
                 "deleter": false,
                 "static": false,
                 "stringifier": false,
@@ -103,7 +101,6 @@
                 "type": "operation",
                 "getter": false,
                 "setter": false,
-                "creator": false,
                 "deleter": true,
                 "static": false,
                 "stringifier": false,
@@ -136,7 +133,6 @@
                 "type": "operation",
                 "getter": true,
                 "setter": false,
-                "creator": false,
                 "deleter": false,
                 "static": false,
                 "stringifier": false,
@@ -169,7 +165,6 @@
                 "type": "operation",
                 "getter": false,
                 "setter": true,
-                "creator": true,
                 "deleter": false,
                 "static": false,
                 "stringifier": false,
@@ -215,7 +210,6 @@
                 "type": "operation",
                 "getter": false,
                 "setter": false,
-                "creator": false,
                 "deleter": true,
                 "static": false,
                 "stringifier": false,
@@ -248,4 +242,4 @@
         "inheritance": null,
         "extAttrs": []
     }
-]
+]
diff --git a/test/syntax/json/iterator.json b/test/syntax/json/iterator.json
@@ -8,7 +8,6 @@
                 "type": "operation",
                 "getter": false,
                 "setter": false,
-                "creator": false,
                 "deleter": false,
                 "static": false,
                 "stringifier": false,
@@ -57,7 +56,6 @@
                 "type": "iterator",
                 "getter": false,
                 "setter": false,
-                "creator": false,
                 "deleter": false,
                 "static": false,
                 "stringifier": false,
@@ -108,7 +106,6 @@
                 "type": "operation",
                 "getter": false,
                 "setter": false,
-                "creator": false,
                 "deleter": false,
                 "static": false,
                 "stringifier": false,
@@ -157,7 +154,6 @@
                 "type": "iterator",
                 "getter": false,
                 "setter": false,
-                "creator": false,
                 "deleter": false,
                 "static": false,
                 "stringifier": false,
@@ -234,7 +230,6 @@
                 "type": "iterator",
                 "getter": false,
                 "setter": false,
-                "creator": false,
                 "deleter": false,
                 "static": false,
                 "stringifier": false,
@@ -261,7 +256,6 @@
                 "type": "iterator",
                 "getter": false,
                 "setter": false,
-                "creator": false,
                 "deleter": false,
                 "static": false,
                 "stringifier": false,
@@ -279,4 +273,4 @@
         "inheritance": null,
         "extAttrs": []
     }
-]
+]