Skip to content
This repository has been archived by the owner on Feb 17, 2023. It is now read-only.

Commit

Permalink
refactor(*) fix tests, linting, powershell artifacts, ci (Kong#134)
Browse files Browse the repository at this point in the history
* feat(powershell) add powershell files
  - add test fixtures
  - add to available targets

* fix(reducer): reduce multidimensional query strings correctly (Kong#93)
* fix(headers) reduce normal using Object.assign
* fix(node) remove extra whitespace in node fixtures
* fix(node) switch from util.inspect to stringify-object module
  - Consistent formatting across Node versions
  - Fixes cross-node-version tests

* chore(lint) fixes
  - Deprecate utils functions (util._extend -> Object.assign). 
  - Invoke assertion `should` methods. 
  - Remove unnecessary escape chars.

* chore(travis) use later versions of node
* chore(test) disable posttest run for now

* style(spelling) fix misspelled attachment
  - when we switched from util._extend to Object.assign, the ordering of
     the headers seemed to be affected, which means we can switch back to
     a normal `reduce` instead of `reduceRight`

* test(requests) disable deep equal for https
  - Mockbin returns http url even when request is for https url

* test(targets) build in skip mechanism for failures
* test(headers) fix headers consistencies w/fixtures
* test(go) fix header order, human readable

Fixes Kong#125, Kong#124 
From Kong#93
  • Loading branch information
darrenjennings authored Apr 25, 2019
1 parent 4c0c5ea commit a5c8e0f
Show file tree
Hide file tree
Showing 81 changed files with 3,073 additions and 250 deletions.
14 changes: 3 additions & 11 deletions .travis.yml
Original file line number Diff line number Diff line change
@@ -1,21 +1,13 @@
language: node_js

node_js:
- iojs
- 0.10
- 0.12
- node
- lts/*
- 8

before_install:
- sudo apt-get update -qq
- sudo apt-get install -qq --yes python3 php5-curl php5-cli

after_script:
- npm run codeclimate

notifications:
webhooks:
urls:
- https://webhooks.gitter.im/e/95c4e911f2486588f98c
on_success: always
on_failure: always
on_start: false
60 changes: 30 additions & 30 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,13 +28,13 @@ Good bug reports are extremely helpful - thank you!
Guidelines for bug reports:

1. **Use the GitHub issue search** — check if the issue has already been
reported.
reported.

2. **Check if the issue has been fixed** — try to reproduce it using the
latest `master` or development branch in the repository.
latest `master` or development branch in the repository.

3. **Isolate the problem** — create a [reduced test
case](http://css-tricks.com/6263-reduced-test-cases/) and a live example.
case](http://css-tricks.com/6263-reduced-test-cases/) and a live example.

A good bug report shouldn't leave others needing to chase you up for more
information. Please try to be as detailed as possible in your report. What is
Expand Down Expand Up @@ -85,48 +85,48 @@ Follow this process if you'd like your work considered for inclusion in the
project:

1. [Fork](http://help.github.com/fork-a-repo/) the project, clone your fork,
and configure the remotes:
and configure the remotes:

```bash
# Clone your fork of the repo into the current directory
git clone https://github.com/<your-username>/<repo-name>
# Navigate to the newly cloned directory
cd <repo-name>
# Assign the original repo to a remote called "upstream"
git remote add upstream https://github.com/Mashape/httpsnippet.git
```
```bash
# Clone your fork of the repo into the current directory
git clone https://github.com/<your-username>/<repo-name>
# Navigate to the newly cloned directory
cd <repo-name>
# Assign the original repo to a remote called "upstream"
git remote add upstream https://github.com/Mashape/httpsnippet.git
```

2. If you cloned a while ago, get the latest changes from upstream:

```bash
git checkout <dev-branch>
git pull upstream <dev-branch>
```
```bash
git checkout <dev-branch>
git pull upstream <dev-branch>
```

3. Create a new topic branch (off the main project development branch) to
contain your feature, change, or fix:
contain your feature, change, or fix:

```bash
git checkout -b <topic-branch-name>
```
```bash
git checkout -b <topic-branch-name>
```

4. Commit your changes in logical chunks. Please adhere to these [git commit
message guidelines](http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html)
or your code is unlikely be merged into the main project. Use Git's
[interactive rebase](https://help.github.com/articles/interactive-rebase)
feature to tidy up your commits before making them public.
message guidelines](http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html)
or your code is unlikely be merged into the main project. Use Git's
[interactive rebase](https://help.github.com/articles/interactive-rebase)
feature to tidy up your commits before making them public.
5. Locally merge (or rebase) the upstream development branch into your topic branch:
```bash
git pull [--rebase] upstream <dev-branch>
```
```bash
git pull [--rebase] upstream <dev-branch>
```
6. Push your topic branch up to your fork:
```bash
git push origin <topic-branch-name>
```
```bash
git push origin <topic-branch-name>
```
7. [Open a Pull Request](https://help.github.com/articles/using-pull-requests/)
with a clear title and description.
Expand Down
Loading

0 comments on commit a5c8e0f

Please sign in to comment.