Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Codemods and refactorings #30292

Draft
wants to merge 15 commits into
base: kasper/csf-factories
Choose a base branch
from

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Jan 17, 2025

Closes #

What I did

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

name before after diff z %
createSize 0 B 0 B 0 B - -
generateSize 77.9 MB 77.9 MB 0 B 2.78 0%
initSize 131 MB 131 MB 2.93 kB -2.36 0%
diffSize 53.4 MB 53.4 MB 2.93 kB -2.37 0%
buildSize 7.19 MB 7.19 MB 0 B 0.43 0%
buildSbAddonsSize 1.85 MB 1.85 MB 0 B 0.22 0%
buildSbCommonSize 195 kB 195 kB 0 B - 0%
buildSbManagerSize 1.87 MB 1.87 MB 0 B 2.95 0%
buildSbPreviewSize 0 B 0 B 0 B - -
buildStaticSize 0 B 0 B 0 B - -
buildPrebuildSize 3.91 MB 3.91 MB 0 B 0.45 0%
buildPreviewSize 3.28 MB 3.28 MB 0 B 0.42 0%
testBuildSize 0 B 0 B 0 B - -
testBuildSbAddonsSize 0 B 0 B 0 B - -
testBuildSbCommonSize 0 B 0 B 0 B - -
testBuildSbManagerSize 0 B 0 B 0 B - -
testBuildSbPreviewSize 0 B 0 B 0 B - -
testBuildStaticSize 0 B 0 B 0 B - -
testBuildPrebuildSize 0 B 0 B 0 B - -
testBuildPreviewSize 0 B 0 B 0 B - -
name before after diff z %
createTime 6.9s 26s 19s 1.19 73.1%
generateTime 20.7s 19s -1s -716ms -1.19 -9%
initTime 13.7s 12.9s -811ms -0.81 -6.3%
buildTime 11.8s 9.4s -2s -392ms -0.13 -25.3%
testBuildTime 0ms 0ms 0ms - -
devPreviewResponsive 5.5s 4.2s -1s -219ms -1.68 🔰-28.4%
devManagerResponsive 3.9s 3.1s -841ms -2.02 🔰-26.8%
devManagerHeaderVisible 609ms 496ms -113ms -1.79 🔰-22.8%
devManagerIndexVisible 620ms 503ms -117ms -1.91 🔰-23.3%
devStoryVisibleUncached 1.7s 1.2s -558ms -4.4 🔰-45%
devStoryVisible 639ms 529ms -110ms -1.75 🔰-20.8%
devAutodocsVisible 553ms 437ms -116ms -1.3 🔰-26.5%
devMDXVisible 516ms 464ms -52ms -1.07 -11.2%
buildManagerHeaderVisible 547ms 502ms -45ms -0.78 -9%
buildManagerIndexVisible 551ms 506ms -45ms -0.77 -8.9%
buildStoryVisible 539ms 495ms -44ms -0.76 -8.9%
buildAutodocsVisible 500ms 429ms -71ms -0.45 -16.6%
buildMDXVisible 459ms 391ms -68ms -1.07 -17.4%

@yannbf yannbf added maintenance User-facing maintenance tasks ci:merged Run the CI jobs that normally run when merged. labels Jan 17, 2025
@yannbf yannbf self-assigned this Jan 17, 2025
Copy link

nx-cloud bot commented Jan 17, 2025

View your CI Pipeline Execution ↗ for commit 503f883.

Command Status Duration Result
nx run-many -t build --parallel=3 ✅ Succeeded 1m 47s View ↗

☁️ Nx Cloud last updated this comment at 2025-01-17 13:27:23 UTC

@storybook-pr-benchmarking
Copy link

storybook-pr-benchmarking bot commented Jan 17, 2025

Package Benchmarks

Commit: 503f883, ran on 17 January 2025 at 13:35:04 UTC

The following packages have significant changes to their size or dependencies:

@storybook/html-vite

Before After Difference
Dependency count 15 15 0
Self size 5 KB 6 KB 🚨 +2 KB 🚨
Dependency size 1.91 MB 1.91 MB 🎉 -12 B 🎉
Bundle Size Analyzer Link Link

@storybook/html-webpack5

Before After Difference
Dependency count 247 247 0
Self size 6 KB 8 KB 🚨 +2 KB 🚨
Dependency size 31.67 MB 31.67 MB 0 B
Bundle Size Analyzer Link Link

@storybook/preact-webpack5

Before After Difference
Dependency count 245 245 0
Self size 6 KB 8 KB 🚨 +2 KB 🚨
Dependency size 31.25 MB 31.25 MB 0 B
Bundle Size Analyzer Link Link

@storybook/react-vite

Before After Difference
Dependency count 87 87 0
Self size 13 KB 14 KB 🚨 +2 KB 🚨
Dependency size 16.48 MB 16.48 MB 🎉 -12 B 🎉
Bundle Size Analyzer Link Link

@storybook/react-webpack5

Before After Difference
Dependency count 323 323 0
Self size 6 KB 8 KB 🚨 +2 KB 🚨
Dependency size 42.87 MB 42.87 MB 0 B
Bundle Size Analyzer Link Link

@storybook/server-webpack5

Before After Difference
Dependency count 255 255 0
Self size 14 KB 15 KB 🚨 +2 KB 🚨
Dependency size 32.65 MB 32.65 MB 0 B
Bundle Size Analyzer Link Link

@storybook/svelte-webpack5

Before After Difference
Dependency count 310 310 0
Self size 6 KB 7 KB 🚨 +2 KB 🚨
Dependency size 39.24 MB 39.24 MB 0 B
Bundle Size Analyzer Link Link

@storybook/vue3-vite

Before After Difference
Dependency count 108 108 0
Self size 15 KB 17 KB 🚨 +2 KB 🚨
Dependency size 42.58 MB 42.58 MB 🎉 -12 B 🎉
Bundle Size Analyzer Link Link

@storybook/vue3-webpack5

Before After Difference
Dependency count 495 495 0
Self size 6 KB 7 KB 🚨 +2 KB 🚨
Dependency size 55.64 MB 55.64 MB 0 B
Bundle Size Analyzer Link Link

@storybook/web-components-vite

Before After Difference
Dependency count 16 16 0
Self size 5 KB 7 KB 🚨 +2 KB 🚨
Dependency size 1.94 MB 1.94 MB 🎉 -12 B 🎉
Bundle Size Analyzer Link Link

@storybook/web-components-webpack5

Before After Difference
Dependency count 245 245 0
Self size 5 KB 7 KB 🚨 +2 KB 🚨
Dependency size 31.29 MB 31.29 MB 0 B
Bundle Size Analyzer Link Link

@storybook/cli

Before After Difference
Dependency count 398 400 🚨 +2 🚨
Self size 503 KB 517 KB 🚨 +14 KB 🚨
Dependency size 75.57 MB 75.59 MB 🚨 +17 KB 🚨
Bundle Size Analyzer Link Link

Core: Add defineConfig helper for main.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:merged Run the CI jobs that normally run when merged. maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant