Dependencies: Upgrades #30515

ndelangen · 2025-02-11T13:43:01Z

What I did

Upgraded a bunch of dependencies

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

stories
unit tests
integration tests
end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

Add or update documentation reflecting your changes
If you are deprecating/removing a feature, make sure to update
MIGRATION.MD

Checklist for Maintainers

When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts
Make sure this PR contains one of the labels below:
Available labels
- bug: Internal changes that fixes incorrect behavior.
- maintenance: User-facing maintenance tasks.
- dependencies: Upgrading (sometimes downgrading) dependencies.
- build: Internal-facing build tooling & test updates. Will not show up in release changelog.
- cleanup: Minor cleanup style change. Will not show up in release changelog.
- documentation: Documentation only changes. Will not show up in release changelog.
- feature request: Introducing a new feature.
- BREAKING CHANGE: Changes that break compatibility in some way with current major version.
- other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

name	before	after	diff	z	%
createSize	0 B	0 B	0 B	-	-
generateSize	80.6 MB	80.6 MB	-1.97 kB	0.82	0%
initSize	80.6 MB	80.6 MB	-1.97 kB	0.82	0%
diffSize	97 B	97 B	0 B	-	0%
buildSize	7.31 MB	7.34 MB	23.5 kB	32.75	0.3%
buildSbAddonsSize	1.9 MB	1.88 MB	-16.4 kB	-242.64	-0.9%
buildSbCommonSize	195 kB	195 kB	0 B	-	0%
buildSbManagerSize	1.88 MB	1.9 MB	23.7 kB	1806.93	1.2%
buildSbPreviewSize	0 B	0 B	0 B	-	-
buildStaticSize	0 B	0 B	0 B	-	-
buildPrebuildSize	3.97 MB	3.97 MB	7.27 kB	99.67	0.2%
buildPreviewSize	3.34 MB	3.36 MB	16.3 kB	24.21	0.5%
testBuildSize	0 B	0 B	0 B	-	-
testBuildSbAddonsSize	0 B	0 B	0 B	-	-
testBuildSbCommonSize	0 B	0 B	0 B	-	-
testBuildSbManagerSize	0 B	0 B	0 B	-	-
testBuildSbPreviewSize	0 B	0 B	0 B	-	-
testBuildStaticSize	0 B	0 B	0 B	-	-
testBuildPrebuildSize	0 B	0 B	0 B	-	-
testBuildPreviewSize	0 B	0 B	0 B	-	-

name	before	after	diff	z	%
createTime	25s	9.6s	-15s -385ms	-0.78	-158.8%
generateTime	20.4s	23.8s	3.4s	3.37	🔺14.5%
initTime	5.2s	4.7s	-420ms	0.57	-8.8%
buildTime	10s	8.6s	-1s -390ms	-0.68	-16.1%
testBuildTime	0ms	0ms	0ms	-	-
devPreviewResponsive	5s	5s	-71ms	-0.56	-1.4%
devManagerResponsive	3.7s	3.8s	25ms	-0.55	0.7%
devManagerHeaderVisible	708ms	706ms	-2ms	-0.65	-0.3%
devManagerIndexVisible	736ms	716ms	-20ms	-0.81	-2.8%
devStoryVisibleUncached	4.1s	3.6s	-567ms	-0.32	-15.6%
devStoryVisible	737ms	734ms	-3ms	-0.83	-0.4%
devAutodocsVisible	693ms	630ms	-63ms	-1.32	🔰-10%
devMDXVisible	711ms	658ms	-53ms	-1.05	-8.1%
buildManagerHeaderVisible	797ms	786ms	-11ms	-0.2	-1.4%
buildManagerIndexVisible	805ms	797ms	-8ms	-0.37	-1%
buildStoryVisible	774ms	770ms	-4ms	-0.15	-0.5%
buildAutodocsVisible	595ms	653ms	58ms	-0.26	8.9%
buildMDXVisible	697ms	526ms	-171ms	-1	-32.5%

Greptile Summary

This PR updates dependencies and modifies Yarn configurations, focusing on log filtering and type safety improvements while adding new accessibility-related exports to the manager UI.

Added log filter for YN0007 in both /scripts/.yarnrc.yml and /code/.yarnrc.yml to reduce peer dependency warning noise
Added accessibility-related icons (AccessibilityIgnoredIcon, ContrastIgnoredIcon) in /code/core/src/manager/globals/exports.ts
Added React's act function to global exports in /code/core/src/manager/globals/exports.ts
Improved type safety in /code/core/src/manager-api/lib/merge.ts with explicit type casting for merge operations

greptile-apps

_{4 file(s) reviewed, 3 comment(s)}
_{Edit PR Review Bot Settings | Greptile}

code/.yarnrc.yml

code/core/src/manager-api/lib/merge.ts

nx-cloud · 2025-02-11T14:07:21Z

View your CI Pipeline Execution ↗ for commit 23c548b.

Command	Status	Duration	Result
`nx run-many -t build --parallel=3`	✅ Succeeded	1m 58s	View ↗

☁️ Nx Cloud last updated this comment at 2025-02-18 09:18:58 UTC

CHC383 · 2025-02-11T18:54:48Z

@ndelangen Hi, could you also add esbuild v0.25.0 to the package.json of code/core to mitigate GHSA-67mh-4wv8-2f99?

julio-rocketchat · 2025-02-12T09:24:16Z

@ndelangen would it also be possible to include an upgrade of core's ws package?

storybook/code/core/package.json

Line 295 in 270cbb9

"ws": "^8.2.3"

It would help mitigate https://nvd.nist.gov/vuln/detail/cve-2024-37890. Thank you

ndelangen · 2025-02-12T14:11:42Z

I'd love to, but right now, I'm completely baffled why the CI is failing the way it is..
I cannot reproduce it locally.

CHC383 · 2025-02-12T19:12:03Z

Is ci/circleci: check the base one that causes the others failed due to failure compilation?

.circleci/config.yml

storybook-pr-benchmarking · 2025-02-13T07:50:05Z

Package Benchmarks

^{Commit: 23c548b, ran on 18 February 2025 at 09:24:54 UTC}

The following packages have significant changes to their size or dependencies:

`@storybook/addon-controls`

	Before	After	Difference
Dependency count	3	3	0
Self size	269 KB	257 KB	🎉 -11 KB 🎉
Dependency size	47 KB	47 KB	0 B
Bundle Size Analyzer	Link	Link

`@storybook/addon-docs`

	Before	After	Difference
Dependency count	13	13	0
Self size	2.25 MB	2.76 MB	🚨 +509 KB 🚨
Dependency size	9.43 MB	9.44 MB	🚨 +13 KB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/addon-essentials`

	Before	After	Difference
Dependency count	32	32	0
Self size	18 KB	18 KB	🚨 +8 B 🚨
Dependency size	15.53 MB	16.04 MB	🚨 +510 KB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/core`

	Before	After	Difference
Dependency count	52	52	0
Self size	19.26 MB	19.36 MB	🚨 +104 KB 🚨
Dependency size	14.19 MB	14.26 MB	🚨 +62 KB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/blocks`

	Before	After	Difference
Dependency count	2	2	0
Self size	626 KB	639 KB	🚨 +13 KB 🚨
Dependency size	1.28 MB	1.28 MB	0 B
Bundle Size Analyzer	Link	Link

`storybook`

	Before	After	Difference
Dependency count	53	53	0
Self size	23 KB	23 KB	0 B
Dependency size	33.45 MB	33.62 MB	🚨 +165 KB 🚨
Bundle Size Analyzer	Link	Link

`sb`

	Before	After	Difference
Dependency count	54	54	0
Self size	1 KB	1 KB	0 B
Dependency size	33.47 MB	33.64 MB	🚨 +165 KB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/cli`

	Before	After	Difference
Dependency count	359	359	0
Self size	279 KB	278 KB	🎉 -115 B 🎉
Dependency size	83.94 MB	84.20 MB	🚨 +254 KB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/codemod`

	Before	After	Difference
Dependency count	275	275	0
Self size	612 KB	622 KB	🚨 +11 KB 🚨
Dependency size	65.52 MB	65.68 MB	🚨 +165 KB 🚨
Bundle Size Analyzer	Link	Link

`create-storybook`

	Before	After	Difference
Dependency count	7	7	0
Self size	10.21 MB	10.29 MB	🚨 +78 KB 🚨
Dependency size	2.24 MB	2.24 MB	0 B
Bundle Size Analyzer	Link	Link

code/core/package.json

ndelangen added 2 commits February 11, 2025 09:49

regen lockfiles

6716712

sync reract types version and deal with some typings issue

00f5199

ndelangen self-assigned this Feb 11, 2025

ndelangen added dependencies ci:normal labels Feb 11, 2025

greptile-apps bot reviewed Feb 11, 2025

View reviewed changes

code/.yarnrc.yml Show resolved Hide resolved

code/core/src/manager-api/lib/merge.ts Show resolved Hide resolved

code/core/src/manager-api/lib/merge.ts Show resolved Hide resolved

Merge branch 'next' into norbert/upgrades-2025-02-11

561ffda

ndelangen added 7 commits February 11, 2025 15:44

fix type issues

123b18a

upgrades

b679528

skip nx cache???

84f5ca1

not the problem

fc1b62d

delete prettier config

b708f00

trying to fix things

44bd271

dunno what's wrong with prettier

b57e9ef

ndelangen added 6 commits February 12, 2025 15:55

merge next

38bb600

Merge branch 'next' into norbert/upgrades-2025-02-11

6c2971f

downgrade prettier

4b2e604

fix check CI step

c4d205c

revert prettier config change

1fa1e65

Merge branch 'next' into norbert/upgrades-2025-02-11

f7a4c76

CHC383 reviewed Feb 12, 2025

View reviewed changes

.circleci/config.yml Outdated Show resolved Hide resolved

.circleci/config.yml Outdated Show resolved Hide resolved

CHC383 reviewed Feb 12, 2025

View reviewed changes

.circleci/config.yml Outdated Show resolved Hide resolved

.circleci/config.yml Outdated Show resolved Hide resolved

.circleci/config.yml Outdated Show resolved Hide resolved

.circleci/config.yml Outdated Show resolved Hide resolved

Discard changes to .circleci/config.yml

19b835e

fixes

42200f4

ndelangen added 4 commits February 13, 2025 09:14

fix

47faeeb

fix

3ac9a5d

try to get unit-tests to pass

779bf76

upgrades

c0928e8

ndelangen requested a review from valentinpalkovic February 13, 2025 10:57

ndelangen added 7 commits February 13, 2025 12:24

upgrades

a3c47c1

Merge branch 'next' into norbert/upgrades-2025-02-11

e65e7ca

fix

98c0514

@babel/runtime@npm:7.26.0

f4e6223

@babel/runtime

63352c8

fix

7abb645

fix

397d101

CHC383 reviewed Feb 13, 2025

View reviewed changes

code/core/package.json Outdated Show resolved Hide resolved

ndelangen added 7 commits February 13, 2025 23:10

fix

bcc8897

fix

e81ff63

upgrades

23ae06e

fix

417d605

fix

ab2635f

Merge branch 'next' into norbert/upgrades-2025-02-11

7d685b8

Merge branch 'next' into norbert/upgrades-2025-02-11

23c548b

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Dependencies: Upgrades #30515

Dependencies: Upgrades #30515

ndelangen commented Feb 11, 2025 •

edited by storybook-pr-benchmarking bot

Loading

greptile-apps bot left a comment

nx-cloud bot commented Feb 11, 2025 •

edited

Loading

CHC383 commented Feb 11, 2025

julio-rocketchat commented Feb 12, 2025 •

edited

Loading

ndelangen commented Feb 12, 2025

CHC383 commented Feb 12, 2025

storybook-pr-benchmarking bot commented Feb 13, 2025 •

edited

Loading

Dependencies: Upgrades #30515

Are you sure you want to change the base?

Dependencies: Upgrades #30515

Conversation

ndelangen commented Feb 11, 2025 • edited by storybook-pr-benchmarking bot Loading

What I did

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

Manual testing

Documentation

Checklist for Maintainers

🦋 Canary release

Greptile Summary

greptile-apps bot left a comment

Choose a reason for hiding this comment

nx-cloud bot commented Feb 11, 2025 • edited Loading

CHC383 commented Feb 11, 2025

julio-rocketchat commented Feb 12, 2025 • edited Loading

ndelangen commented Feb 12, 2025

CHC383 commented Feb 12, 2025

storybook-pr-benchmarking bot commented Feb 13, 2025 • edited Loading

Package Benchmarks

@storybook/addon-controls

@storybook/addon-docs

@storybook/addon-essentials

@storybook/core

@storybook/blocks

storybook

sb

@storybook/cli

@storybook/codemod

create-storybook

ndelangen commented Feb 11, 2025 •

edited by storybook-pr-benchmarking bot

Loading

nx-cloud bot commented Feb 11, 2025 •

edited

Loading

julio-rocketchat commented Feb 12, 2025 •

edited

Loading

storybook-pr-benchmarking bot commented Feb 13, 2025 •

edited

Loading

`@storybook/addon-controls`

`@storybook/addon-docs`

`@storybook/addon-essentials`

`@storybook/core`

`@storybook/blocks`

`storybook`

`sb`

`@storybook/cli`

`@storybook/codemod`

`create-storybook`