Add default value for DerivativeData and LicenseConfig #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bonnie57
requested review from
LeoHChen,
DonFungible,
edisonz0718,
jacob-tucker,
AndyBoWu,
allenchuang and
bpolania
as code owners
bonnie57
commented
Feb 17, 2025
DracoLi
reviewed
Feb 18, 2025
bonnie57
force-pushed
the
bonnie/dev
branch
2 times, most recently
from
229c5c1 to
d5af98e
Compare
bonnie57
force-pushed
the
bonnie/dev
branch
2 times, most recently
from
d5af98e to
8a628b6
Compare
DracoLi
reviewed
Feb 20, 2025
DracoLi
reviewed
Feb 20, 2025
| */ | ||
| maxRts?: number | string; | ||
| /** | ||
| * The maximum revenue share percentage allowed for minting the License Tokens. Must be between 0 and 100 (where 100% represents 100_000_000). |
Add default value for LicenseConfig Update the doc about multiple line Update the doc Update event with link Update zero address Modify licenseConfig logic Refactor via comments Enhance LicenseTermsData type Make licensingConfig required in the setLicensingConfig method Update default show style
bonnie57
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add default value including :
Derivative Data
maxMintingFee: Default 0maxRts: 100_000_000maxRevenueShare: 100 (this is a percentage, SDK converts to 100m before calling protocol)Licensing Config
isSet: falsemintingFee: 0licensingHook: zeroAddresshookData: zeroAddresscommercialRevShare: 0disabled: falseexpectMinimumGroupRewardShare: 0expectGroupRewardPool: zeroAddress