-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update the route syntax for it to be properly registered #72
Conversation
🦋 Changeset detectedLatest commit: 4e3fee0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Oh sidenote: I've added |
Hey @boazpoolman cheers for the contribution 🙏 will take a look as soon as we have a chance |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution,
LGTM!
if you can just remove the auth:false
it does make the route accessible immediately indeed, but we generally like if for users to want that intentionally
Signed-off-by: Boaz Poolman <[email protected]>
Done :) |
You should be able to get the CI passing if you merge or rebase main, there was an issue fixed yesterday |
What does it do?
Properly register the server routes.
Why is it needed?
Right now the example route doesn't work when you init a new plugin.
How to test it?
Unsure about the test flow of this repository.
I've just based it off of the code I found.
Related issue(s)/PR(s)