Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update the route syntax for it to be properly registered #72

Merged
merged 4 commits into from
Feb 11, 2025

Conversation

boazpoolman
Copy link
Contributor

What does it do?

Properly register the server routes.

Why is it needed?

Right now the example route doesn't work when you init a new plugin.

How to test it?

Unsure about the test flow of this repository.
I've just based it off of the code I found.

Related issue(s)/PR(s)

Copy link

changeset-bot bot commented Jan 13, 2025

🦋 Changeset detected

Latest commit: 4e3fee0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@strapi/sdk-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@boazpoolman
Copy link
Contributor Author

Oh sidenote: I've added auth: false to the example route.
That way it just works straight out of the box. No need to setup permissions.
This is optional. Let me know if you want me to remove it.

@hanpaine
Copy link

Hey @boazpoolman cheers for the contribution 🙏 will take a look as soon as we have a chance

Copy link
Member

@Bassel17 Bassel17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution,
LGTM!
if you can just remove the auth:false
it does make the route accessible immediately indeed, but we generally like if for users to want that intentionally

Signed-off-by: Boaz Poolman <[email protected]>
@boazpoolman boazpoolman requested a review from Bassel17 February 6, 2025 13:47
@boazpoolman
Copy link
Contributor Author

Done :)

@innerdvations
Copy link
Collaborator

innerdvations commented Feb 11, 2025

You should be able to get the CI passing if you merge or rebase main, there was an issue fixed yesterday

@Bassel17 Bassel17 merged commit 9747836 into strapi:main Feb 11, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Fixed/Shipped
Development

Successfully merging this pull request may close these issues.

4 participants