fix(og): fixed open graph field names #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`:` Isn't allowed character for a field when the grapqhl plugin tries to generate definitions for it. This makes the build of the app fail if one has both Graphql Plugin and Seo plugin and adds an seo component to some content-type. Changing the names of the open-graphql components to not include the `:` fixes this bug.
|
@jhoward1994 Hi sorry to directly mention you but, I'd be nice if we could get this merged as soon as possible and you are the person I remember being most active in these types of PRs. Could you please look at it or assign it to someone ? |
|
+1 |
4 similar comments
|
+1 |
|
+1 |
|
+1 |
|
+1 |
jhoward1994
approved these changes
Jan 23, 2025
There was a problem hiding this comment.
Thanks for your PR and for all your patience with this 🙏🏻. To me this PR looks good & is working in conjunction with the graphQL plugin.
@Mcastres would you be able to take a look at this too please?
|
This PR needs to be merged ASAP as it can produce this serious issue strapi/strapi#18664 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The : character is not allowed in field names when the GraphQL plugin generates type definitions. This restriction causes the app build to fail when both the GraphQL plugin and the SEO plugin are used, specifically when an SEO component is added to a content type.
Changes
Screenshots
Related Issues
This PR addresses the issues raised in:
Both issues suggest renaming attributes as a potential solution but also note that the preview feature in the admin panel stops working. This PR resolves both the build failure and the preview functionality issue.
Testing