Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a new create_options argument to new() and setup() #848

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Add a new create_options argument to new() and setup() #848

wants to merge 3 commits into from

Commits on Apr 24, 2023

  1. Add 'create_options' to device new() and setup() methods 

    Add the ability for callers to specify the DmOptions value to use
when creating or setting up lineardev, thindev, thinpooldev, and
cachedev.

The DmOptions value is wrapped in an Option which if set to None
gives the previous devicemapper-rs default behaviour.

This allows clients of the crate to opt in to controlling device
visibility and other DmOptions/DmUdevFlags behaviour when creating
or setting up devices.
    @bmr-cymru
    bmr-cymru committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    03f9f8b View commit details
    Browse the repository at this point in the history

  2. Allow clippy::too_many_arguments for CacheDev new() and setup()

    @bmr-cymru
    bmr-cymru committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    c9139b0 View commit details
    Browse the repository at this point in the history

  3. Add an additional Option<DmOptions> parameter to resume() 

    Allow callers to control DmOptions and udev flags on resume. This
allows clients of the crate to explicitly control the flags used
on device resume.

If no DmOptions is supplied to a call the library reverts to the
long-standing default behaviour.
    @bmr-cymru
    bmr-cymru committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    3f78077 View commit details
    Browse the repository at this point in the history