web: selecting the programming language by pressing Enter key #7484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yash Kumar <[email protected]>
KYash03
changed the title
|
Thank you! |
thecodrr
requested changes
Feb 11, 2025
| @@ -236,6 +236,20 @@ type LanguageSelectorProps = { | |||
| function LanguageSelector(props: LanguageSelectorProps) { | |||
| const { onLanguageSelected, selectedLanguage, onClose } = props; | |||
| const [languages, setLanguages] = useState(Languages); | |||
| const [searchQuery, setSearchQuery] = useState(""); | |||
There was a problem hiding this comment.
This state is unnecessary.
| @@ -258,9 +272,15 @@ function LanguageSelector(props: LanguageSelectorProps) { | |||
| zIndex: 999, | |||
| mt: 1 | |||
| }} | |||
| value={searchQuery} | |||
| const query = e.target.value.toLowerCase(); | ||
| setSearchQuery(query); |
| onChange={(e) => { | ||
| if (!e.target.value) return setLanguages(Languages); |
Comment on lines
+241
to
+252
| const onKeyDown = useCallback( | ||
| (e: React.KeyboardEvent) => { | ||
| if (e.key === "Enter" && languages.length > 0) { | ||
| onLanguageSelected(languages[0].filename); | ||
| e.preventDefault(); | ||
| } else if (e.key === "Escape") { | ||
| onClose(); | ||
| e.preventDefault(); | ||
| } | ||
| }, | ||
| [languages, onLanguageSelected, onClose] | ||
| ); |
There was a problem hiding this comment.
This can be inline. No need for useCallback.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #7284
This PR adds support for selecting the programming language by pressing the Enter key.