define not_parallel_for non-debug builds and header fixes #4539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to move not_parallel_for out from the #ifdef statement since otherise it is only defined for debug builds but it is needed unconditionally in the code. Besides that this fixes a lot of cases where functions or types were used but the corresponding header file was not included. Those were discovered by doing release builds with precompiled headers turned off. Most of those gaps likely were hidden by precompiled headers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to move not_parallel_for out from the #ifdef statement since otherise it is only defined for debug builds but it is needed unconditionally in the code.
Besides that this fixes a lot of cases where functions or types were used but the corresponding header file was not included. Those were discovered by doing release builds with precompiled headers turned off. Most of those gaps likely were hidden by precompiled headers.