Re-enable linkcheck as per updates in #120 #145
+12
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just as a note, I tested the |
Nolski
commented
Jan 28, 2025
| @@ -5,21 +5,19 @@ | |||
|
|
|||
| GEO OSE seeks to build upon the POSE solicitation by targeting community building programs specific to the geospace sciences, ocean sciences, Earth sciences, and polar sciences. As per the solicitation: | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
These edits below were due to the npm run lint command failing. This command should now succeed. I don't see any specific github action that runs this command though. @RichardLitt do you know if we use this anymore? I may just be missing where it is run.
There was a problem hiding this comment.
Take a look at package.json, and build.sh. If there is something missing, we should open a new issue and document this in the README.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should allow working builds along with link-check working once again. Resolves #120