Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add title and body options (create-scaffold-pr) #1550

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

int128
Copy link
Contributor

@int128 int128 commented Feb 26, 2024

Feature request

It would be nice if we can set a custom title or body to create-scaffold-pr action.

This PR will add the options. It keeps the current behavior as possible.

@int128 int128 marked this pull request as ready for review February 26, 2024 04:11
pull-request-title:
description: The title of the pull request. This should be a single-line string for gh command.
required: false
default: Scaffold a working directory
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$TFACTION_TARGET is missed.
It's good to support any template notation.

@suzuki-shunsuke
Copy link
Owner

Thank you for your contribution!

@suzuki-shunsuke
Copy link
Owner

It's good to support changing pull request title and body, but I'm wondering the interface.
Basically, tfaction manages settings by configuration files tfaction-root.yaml and tfaction.yaml rather than GitHub Actions inputs.
So I'm wondering if the pull request title and body should be configured by tfaction-root.yaml.

@suzuki-shunsuke
Copy link
Owner

And I'm also wondering how tfaction should support a template notation.

@int128
Copy link
Contributor Author

int128 commented Feb 27, 2024

I created the issue as #1553.

This implementation is just one of solutions. Please consider the best design.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants