Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable you to create a follow up pr file #1801

Merged
merged 13 commits into from
Sep 21, 2024

Conversation

suzuki-shunsuke
Copy link
Owner

@suzuki-shunsuke suzuki-shunsuke commented Sep 20, 2024

Close #1799

If terraform apply fails, create-follow-pr action creates or updates a file .tfaction/failed-prs in the working directory and creates a follow up pull request.

e.g.

# This file is created and updated by tfaction for follow up pull requests.
# You can remove this file safely.
https://github.com/suzuki-shunsuke/terraform-example/pull/1

@suzuki-shunsuke suzuki-shunsuke added the enhancement New feature or request label Sep 20, 2024
@suzuki-shunsuke
Copy link
Owner Author

@suzuki-shunsuke
Copy link
Owner Author

Removed the setting and change the default behaviour.

@suzuki-shunsuke suzuki-shunsuke added this to the v1.6.0 milestone Sep 20, 2024
@suzuki-shunsuke
Copy link
Owner Author

@suzuki-shunsuke
Copy link
Owner Author

suzuki-shunsuke commented Sep 20, 2024

Create a directory .tfaction

Rename the file .tfaction-failed-prs to .tfaction/failed-prs.

Even if we will need to add other files related to tfaction, we can avoid cluttering up working directories.

@suzuki-shunsuke
Copy link
Owner Author

About conflict

.tfaction/failed-prs may cause conflicts.
To avoild conflicts, we can change file names per pull request like .tfaction/failed-pr-<pr number>.
If conflicts would be troublesome, we need to consider this kind of approach, but for now I think the conflict is not bad.
The conflict clarifies that others are working in the same working directory.
And the conflict encourages users to update branches.

@suzuki-shunsuke
Copy link
Owner Author

@suzuki-shunsuke suzuki-shunsuke merged commit d91ee1f into main Sep 21, 2024
12 checks passed
@suzuki-shunsuke suzuki-shunsuke deleted the feat-create-follow-up-pr-file branch September 21, 2024 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create or update a file for follow up pull requests
1 participant