Add terraform execution condition #436
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
semnil
commented
Aug 1, 2022
Comment on lines
160
to
163
| core.setOutput('terraform_targets', terraformTargetObjs); | ||
| if (tfmigrateObjs.length == 0) { | ||
| // Running terraform when tfmigrate has nothing to do | ||
| core.setOutput('terraform_targets', terraformTargetObjs); | ||
| } |
There was a problem hiding this comment.
The differences other than these changes are the result of running npm run build.
There was a problem hiding this comment.
Thank you for your contribution.
I think this change has a problem.
tfaction supports Monorepo, and doesn't restrict the use case that Terraform and tfmigrate are run in multiple working directories.
This change restricts those use cases and includes a breaking change.
#386 intends to prevent both terraform and tfmigrate from being run in the same working directory (I fixed the issue title).
|
I'm sorry that I misunderstood the content of the issue. 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had an incident where I forgot to add a skip label and the resource was deleted. 😢
I don't think it is necessary to run terraform as long as the goal is to run tfmigrate.
Also, I believe the following issues can be resolved.
ref: #386
Please let me know if additional action is needed and I will respond. 😄