[build.ps1] build swift-lmdb using cmake #77562
Conversation
|
swiftlang/swift-lmdb#7 @swift-ci please smoke test |
|
swiftlang/swift-lmdb#7 @swift-ci build toolchain |
utils/build.ps1
Outdated
| @@ -2439,6 +2439,17 @@ function Test-Format { | |||
| } | |||
| } | |||
|
|
|||
| function Build-LMDB() { | |||
| Build-SPMProject ` | |||
There was a problem hiding this comment.
Should this be Build-CMakeProject? This doesn't match the commit message. Do you have numbers for what the toolchain size impact is on static vs dynamic builds?
There was a problem hiding this comment.
Good catch! Admittedly I'm quite new to this and haven't been able to compile Swift on Windows at all. So, I don't have those numbers right now.
|
swiftlang/swift-lmdb#7 @swift-ci build toolchain |
3 similar comments
|
swiftlang/swift-lmdb#7 @swift-ci build toolchain |
|
swiftlang/swift-lmdb#7 @swift-ci build toolchain |
|
swiftlang/swift-lmdb#7 @swift-ci build toolchain |
utils/build.ps1
Outdated
| -Bin (Get-HostProjectBinaryCache LMDB) ` | ||
| -Arch $Arch ` | ||
| -Platform Windows ` | ||
| -UseBuiltCompilers C ` |
There was a problem hiding this comment.
Is there a reason to use clang-cl instead of cl here?
There was a problem hiding this comment.
No particular reason. I've updated this patch to use the same approach you took in #71422.
One question about that PR: how close is it to being able to merge? I realize that the next step of this will probably be to get a cmake build of swift-docc working since the goal is to use swift-docc as a dependency to SourceKit-LSP which currently has a cmake build.
matthewbastien
force-pushed
the
swift-lmdb
branch
from
8b6f0ab
to
4d937c8
Compare
|
swiftlang/swift-lmdb#6 @swift-ci build toolchain |
This is tracked by rdar://139431575 as a part of swiftlang/vscode-swift#562
Build swift-lmdb on Windows using newly added cmake files in the repository. This change makes it so that IndexStoreDB uses the same version of LMDB as swift-docc and enables SourceKit-LSP to use swift-docc as a dependency to fulfill documentation requests on behalf of the VS Code Swift extension.