Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(styles): updated borders utility #3751

Open
wants to merge 32 commits into
base: main
Choose a base branch
from
Open

Conversation

myrta2302
Copy link
Contributor

No description provided.

@myrta2302 myrta2302 requested a review from a team as a code owner October 14, 2024 12:48
@myrta2302 myrta2302 linked an issue Oct 14, 2024 that may be closed by this pull request
1 task
Copy link

changeset-bot bot commented Oct 14, 2024

🦋 Changeset detected

Latest commit: 8ec3e60

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@swisspost/design-system-documentation Patch
@swisspost/design-system-styles Patch
@swisspost/design-system-components-angular-workspace Patch
@swisspost/design-system-components Patch
@swisspost/internet-header Patch
@swisspost/design-system-intranet-header-workspace Patch
@swisspost/design-system-nextjs-integration Patch
@swisspost/design-system-styles-primeng-workspace Patch
@swisspost/design-system-intranet-header Patch
@swisspost/design-system-styles-primeng Patch
@swisspost/design-system-components-react Patch
@swisspost/design-system-components-angular Patch
@swisspost/design-system-intranet-header-showcase Patch
@swisspost/design-system-tokens Patch
@swisspost/design-system-icons Patch
@swisspost/design-system-migrations Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@myrta2302 myrta2302 requested review from alizedebray and removed request for oliverschuerch October 15, 2024 09:48
@swisspost-bot
Copy link
Contributor

swisspost-bot commented Oct 15, 2024

Related Previews

@myrta2302 myrta2302 changed the title chore(Styles): Updated borders utility chore(styles): updated borders utility Oct 16, 2024
@myrta2302 myrta2302 requested a review from a team as a code owner November 8, 2024 08:06
Copy link

sonarqubecloud bot commented Dec 6, 2024

@oliverschuerch oliverschuerch removed the request for review from alizedebray January 30, 2025 08:31
@oliverschuerch oliverschuerch requested review from oliverschuerch and alizedebray and removed request for oliverschuerch January 30, 2025 08:31
Copy link
Contributor

@alizedebray alizedebray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@myrta2302 I let you update the PR, just request my review again when it's ready. Thank you!

.changeset/bright-dragons-exist.md Outdated Show resolved Hide resolved
pnpm-lock.yaml Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert changes to this file.

packages/styles/src/themes/bootstrap/_utilities.scss Outdated Show resolved Hide resolved
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The mock utility tokens should be added to the packages/styles/src/tokens/_utilities.scss file if you want to be able to use them with the from-tokens function.

But it would probably be easier to ask for the border tokens and use them directly.

packages/styles/src/utilities/_variables.scss Outdated Show resolved Hide resolved
packages/styles/src/utilities/_variables.scss Outdated Show resolved Hide resolved
packages/styles/src/utilities/_variables.scss Outdated Show resolved Hide resolved
packages/styles/src/utilities/_variables.scss Outdated Show resolved Hide resolved
packages/styles/src/tokens/_post-theme.scss Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[utilities]: borders
3 participants