Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme.md #776

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Update readme.md #776

wants to merge 2 commits into from

Conversation

MtFBella109
Copy link

Added missing dependencies and a Hint, that you need to do the Steby by workstation first

@MtFBella109 MtFBella109 requested a review from ereio as a code owner July 31, 2023 19:54
Copy link
Member

@0x1a8510f2 0x1a8510f2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just me being nitpicky as ever :P good catch though, and thanks for the PR!

2. ```apt install libgtk-3-dev liblzma-dev libblkid-dev libsecret-1-dev libolm-dev libolm3 libsqlite3-dev libjsoncpp-dev libsqlcipher-dev``` or distribution equivalent
3. ```flutter build linux && flutter build bundle```
2. ```apt install libgtk-3-dev liblzma-dev libblkid-dev libsecret-1-dev libolm-dev libolm3 libsqlite3-dev libjsoncpp-dev libsqlcipher-dev libssl-dev lib32stdc++-12-dev libstdc++-12-dev``` or distribution equivalent
3. ```flutter build linux && flutter build bundle``` (Don't forget to do the Steps by Workstation first
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nitpicky of me, but I think Steps and Workstation shouldn't be capitalised. Maybe changing by to under will be more clear too. Something like:

Suggested change
3. ```flutter build linux && flutter build bundle``` (Don't forget to do the Steps by Workstation first
3. ```flutter build linux && flutter build bundle``` (Don't forget to do the steps under workstation first.)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah make sense, a good hint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants