Upgrade BouncyCastle dependencies #583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a small version bump for the Bouncy Castle dependencies:
org.bouncycastle.bcprov-jdk15on:1.70→org.bouncycastle.bcprov-jdk18on:1.80org.bouncycastle.bcmail-jdk15on:1.70→org.bouncycastle.bcmail-jdk18on:1.80This upgrade was motivated by the known CVEs affecting the current versions of these Bouncy Castle dependencies. I haven't tried to do an analysis to tell if these CVEs are applicable in the context of Tabula or not, but it seemed like upgrading was pretty straightforward. I believe Dependabot didn't catch this since the Maven artifact was effectively replaced (from
jdk15ontojdk18on).I haven't tested this PR extensively, but the code compiled without issues, it passed tests in CI, and it also still worked with some internal tooling I tried out. I also haven't tested with different JDK versions, but based on the Bouncy Castle artifact name change, I'm assuming that this change won't work for JDK versions < 18 (I'm also not sure what the minimum JDK version
tabula-javaitself supports).