-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] fix(cdk): focusout event not firing in safari #10232
base: main
Are you sure you want to change the base?
Conversation
Tests completed successfully ✅Good job 🔥 |
Visit the preview URL for this PR (updated for commit 4191c04): https://taiga-previews-demo--pr10232-splincode-fix-issues-9836-lika72t1.web.app (expires Sat, 25 Jan 2025 11:57:06 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 73dddc3c665194f3e11f18c16aeb71af4c289c37 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10232 +/- ##
==========================================
- Coverage 65.78% 65.77% -0.02%
==========================================
Files 1240 1240
Lines 16223 16226 +3
Branches 2321 2308 -13
==========================================
Hits 10672 10672
- Misses 5353 5427 +74
+ Partials 198 127 -71
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
BundleMonFiles updated (1)
Unchanged files (4)
Total files change +15B 0% Groups updated (1)
Final result: ✅ View report in BundleMon website ➡️ |
Playwright test results
Details
Failed testswebkit › tests/kit/tabs/tabs.pw.spec.ts › Tabs › Examples › complex › shows only a single dropdown for the nested item (with [tuiDropdown]) inside more section Skipped testswebkit › tests/addon-commerce/input-card-group.pw.spec.ts › InputCardGroup › Examples › input card grouped with validation |
ba14114
to
4191c04
Compare
Let's keep this open for now until I have time to take a look myself. That's a delicate piece of code and while this change fixes the issue I want to first investigate it myself before adding this workaround. |
Fixes #9836