feat(core): `Dialog`/`Dropdown` use `CloseWatcher` to close on Android native back button #10300

waterplea · 2025-02-03T14:04:07Z

Fixes #

lumberjack-bot · 2025-02-03T14:04:14Z

Failed tests ❌

Before (main) ← Diff → After (local)

tests-legacy-input-date-ti-491f0-lete-date---validator-error-chromium-retry2/04-input-data-time-with-validator.diff.png

tests-kit-input-number-inp-2a293-annot-be-violated-via-steps-chromium-retry2/input-number-with-disabled-step-up.diff.png

tests-legacy-input-time-in-da817-InputTime-Examples-dropdown-chromium-retry2/02-input-time-dropdown-2.diff.png

tests-legacy-input-year-in-c4c1b-ect-year-entry-0040-blur-40-chromium-retry2/06-input-year.diff.png

tests-legacy-input-year-in-7c81a-ur-can-not-be-less-than-min-chromium-retry2/08-input-year.diff.png

tests-legacy-input-year-in-e6969-rect-year-entry-0000-blur-0-chromium-retry2/04-input-year.diff.png

tests-kit-input-number-inp-2a293-annot-be-violated-via-steps-webkit-retry2/input-number-with-disabled-step-up.diff.png

tests-legacy-input-date-ti-491f0-lete-date---validator-error-webkit-retry2/04-input-data-time-with-validator.diff.png

tests-legacy-input-time-in-da817-InputTime-Examples-dropdown-webkit-retry2/02-input-time-dropdown-2.diff.png

tests-legacy-input-year-in-7c81a-ur-can-not-be-less-than-min-webkit-retry2/08-input-year.diff.png

tests-legacy-input-year-in-c4c1b-ect-year-entry-0040-blur-40-webkit-retry2/06-input-year.diff.png

tests-legacy-input-year-in-e6969-rect-year-entry-0000-blur-0-webkit-retry2/04-input-year.diff.png

_{(updated for commit d56e4c0)}

github-actions · 2025-02-03T14:09:26Z

Visit the preview URL for this PR (updated for commit d56e4c0):

https://taiga-previews-demo--pr10300-close-watcher-demo-qa2hvg28.web.app

_{(expires Tue, 11 Feb 2025 11:15:26 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: 73dddc3c665194f3e11f18c16aeb71af4c289c37}

codecov · 2025-02-03T14:09:54Z

Codecov Report

Attention: Patch coverage is 27.65957% with 34 lines in your changes missing coverage. Please review.

Project coverage is 65.67%. Comparing base (fa4c079) to head (d56e4c0).

Files with missing lines	Patch %	Lines
.../components/sheet-dialog/sheet-dialog.component.ts	17.64%	14 Missing ⚠️
projects/cdk/observables/close-watcher.ts	15.38%	11 Missing ⚠️
...ore/directives/dropdown/dropdown-open.directive.ts	30.00%	7 Missing ⚠️
...cts/core/components/dialog/dialog-close.service.ts	75.00%	1 Missing ⚠️
...rojects/core/components/dialog/dialog.component.ts	50.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #10300      +/-   ##
==========================================
- Coverage   65.74%   65.67%   -0.08%     
==========================================
  Files        1243     1244       +1     
  Lines       16257    16282      +25     
  Branches     2413     2356      -57     
==========================================
+ Hits        10688    10693       +5     
- Misses       5219     5376     +157     
+ Partials      350      213     -137

Flag	Coverage Δ
summary	`65.67% <27.65%> (-0.08%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

bundlemon · 2025-02-03T14:25:39Z

BundleMon

Files updated (2)

Status	Path	Size	Limits
✅	demo/browser/main.(hash).js	309.2KB (+173B +0.05%)	+10%
✅	demo/browser/vendor.(hash).js	260.35KB (+53B +0.02%)	+10%

Unchanged files (3)

Status	Path	Size	Limits
✅	demo/browser/runtime.(hash).js	46.86KB	+10%
✅	demo/browser/styles.(hash).css	20.93KB	+10%
✅	demo/browser/polyfills.(hash).js	11.18KB	+10%

Total files change +217B +0.03%

Groups updated (1)

Status	Path	Size	Limits
✅	demo/browser/*..js	7.96MB (+2.48KB +0.03%)	-

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

github-actions · 2025-02-03T15:16:28Z

Playwright test results

2084 passed
1 flaky
83 skipped

Details

Open report ↗︎
2168 tests across 73 suites
32 minutes, 34 seconds
49a3bd3

Flaky tests

webkit › tests/legacy/input-phone/input-phone.pw.spec.ts › InputPhone › iphone-x › [countryCode]="+7" & [phoneMaskAfterCountryCode]="(###) ###-##-##" › Text selection › Select range and press "Backspace" › +7 (912) 345-|67|-89 => Backspace => +7 (912) 345-|89

Skipped tests

webkit › tests/addon-commerce/input-card-group.pw.spec.ts › InputCardGroup › Examples › input card grouped with validation
webkit › tests/addon-commerce/input-card-group.pw.spec.ts › InputCardGroup › Examples › input card grouped with saved cards
webkit › tests/addon-commerce/input-card-group.pw.spec.ts › InputCardGroup › Examples › expired field should be clickable after reset of prefilled value
webkit › tests/addon-doc/navigation.pw.spec.ts › Navigation › anchor links navigation works › scroll to "tui-doc-example"
webkit › tests/addon-doc/navigation.pw.spec.ts › Navigation › anchor links navigation works › scroll to "tui-doc-code"
webkit › tests/addon-doc/navigation.pw.spec.ts › Navigation › anchor links navigation works › scroll after click on link with anchor
webkit › tests/addon-doc/navigation.pw.spec.ts › Navigation › getting started / [light mode]
webkit › tests/addon-doc/navigation.pw.spec.ts › Navigation › getting started / [dark mode]
webkit › tests/core/data-list/data-list.pw.spec.ts › DataList › Submenu
webkit › tests/core/data-list/data-list.pw.spec.ts › DataList › Form control
webkit › tests/core/data-list/data-list.pw.spec.ts › DataList › Complex
webkit › tests/core/data-list/data-list.pw.spec.ts › DataList › Options with long text
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 320x480 › Dialog with confirmation works › Prompt
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 320x480 › Dialog with confirmation works › Pristine form does not show confirmation
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 320x480 › Dialog with confirmation works › Dirty form shows confirmation
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 320x480 › Dialog with confirmation works › Form is reset to pristine
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 320x480 › A dialog and a nested dialog are open correctly
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 320x480 › Mobile dialog works
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 320x480 › Dialog with directive works
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 320x480 › Show simple
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 320x480 › Show simple + custom button
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 720x900 › Dialog with confirmation works › Prompt
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 720x900 › Dialog with confirmation works › Pristine form does not show confirmation
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 720x900 › Dialog with confirmation works › Dirty form shows confirmation
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 720x900 › Dialog with confirmation works › Form is reset to pristine
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 720x900 › A dialog and a nested dialog are open correctly
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 720x900 › Mobile dialog works
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 720x900 › Dialog with directive works
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 720x900 › Show simple
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 720x900 › Show simple + custom button
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 1024x900 › Dialog with confirmation works › Prompt
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 1024x900 › Dialog with confirmation works › Pristine form does not show confirmation
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 1024x900 › Dialog with confirmation works › Dirty form shows confirmation
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 1024x900 › Dialog with confirmation works › Form is reset to pristine
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 1024x900 › A dialog and a nested dialog are open correctly
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 1024x900 › Mobile dialog works
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 1024x900 › Dialog with directive works
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 1024x900 › Show simple
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 1024x900 › Show simple + custom button
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 1620x1024 › Dialog with confirmation works › Prompt
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 1620x1024 › Dialog with confirmation works › Pristine form does not show confirmation
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 1620x1024 › Dialog with confirmation works › Dirty form shows confirmation
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 1620x1024 › Dialog with confirmation works › Form is reset to pristine
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 1620x1024 › A dialog and a nested dialog are open correctly
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 1620x1024 › Mobile dialog works
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 1620x1024 › Dialog with directive works
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 1620x1024 › Show simple
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 1620x1024 › Show simple + custom button
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › Prompt - 320x480
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › Prompt - 720x900
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › Prompt - 1024x900
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › Prompt - 1620x1024
webkit › tests/core/surface/surface.pw.spec.ts › Surface › Layers
webkit › tests/kit/carousel/carousel.pw.spec.ts › Carousel › should show next item after drag
webkit › tests/kit/dropdown-hover/dropdown-hover.pw.spec.ts › DropdownHover › Examples › With DropdownMobile › Closes dropdown on click on overlay
webkit › tests/kit/dropdown-hover/dropdown-hover.pw.spec.ts › DropdownHover › Examples › With DropdownMobile › Opens mobile version of dropdown on the 2nd time click
webkit › tests/kit/input-number/input-number.pw.spec.ts › InputNumber › API › [prefix] & [postfix] props › [prefix]="$" & [postfix]="" › textfield does not contain any digit (only suffixes) => clear inputNumber.textfield value on blur
webkit › tests/kit/input-number/input-number.pw.spec.ts › InputNumber › API › [prefix] & [postfix] props › [prefix]="" & [postfix]="kg" › textfield does not contain any digit (only suffixes) => clear inputNumber.textfield value on blur
webkit › tests/kit/input-number/input-number.pw.spec.ts › InputNumber › API › [prefix] & [postfix] props › [prefix]="$" & [postfix]="kg" › textfield does not contain any digit (only suffixes) => clear inputNumber.textfield value on blur
webkit › tests/kit/range/range.pw.spec.ts › TuiRange › examples page › change selected range on click › click on the beginning of the track changes only nearest (left) slider
webkit › tests/kit/range/range.pw.spec.ts › TuiRange › examples page › change selected range on click › click on the end of the track changes only nearest (right) slider
webkit › tests/kit/range/range.pw.spec.ts › TuiRange › examples page › change selected range on click › click between two thumbs triggers only nearest thumb
webkit › tests/kit/range/range.pw.spec.ts › TuiRange › examples page › keyboard interactions › basic range (from 0 to 1000 with 250 steps). Initial value [0, 250] › pressing of Arrow Right increases by one step (after focus on right slider)
webkit › tests/kit/range/range.pw.spec.ts › TuiRange › examples page › keyboard interactions › basic range (from 0 to 1000 with 250 steps). Initial value [0, 250] › pressing of Arrow Right increases by one step (after focus on left slider)
webkit › tests/kit/range/range.pw.spec.ts › TuiRange › examples page › keyboard interactions › basic range (from 0 to 1000 with 250 steps). Initial value [0, 250] › pressing of Arrow Left decreases by one step (after setting right thumb active via click)
webkit › tests/kit/range/range.pw.spec.ts › TuiRange › examples page › keyboard interactions › basic range (from 0 to 1000 with 250 steps). Initial value [0, 250] › cannot set left thumb more than right thumb (by Arrow Right)
webkit › tests/kit/range/range.pw.spec.ts › TuiRange › examples page › keyboard interactions › basic range (from 0 to 1000 with 250 steps). Initial value [0, 250] › cannot set right thumb less than left thumb (by ArrowLeft)
webkit › tests/kit/range/range.pw.spec.ts › TuiRange › examples page › keyboard interactions › range with keySteps (from 0 to 1M) with 8 steps. Initial value [0, 100_000] › ArrowUp increases value of the focused slider
webkit › tests/kit/range/range.pw.spec.ts › TuiRange › examples page › keyboard interactions › range with keySteps (from 0 to 1M) with 8 steps. Initial value [0, 100_000] › ArrowDown decreases value of the focused slider
webkit › tests/kit/range/range.pw.spec.ts › TuiRange › examples page › keyboard interactions › range with keySteps (from 0 to 1M) with 8 steps. Initial value [0, 100_000] › cannot set position of the LEFT slider MORE THAN position of the RIGHT slider (by ArrowUp)
webkit › tests/kit/range/range.pw.spec.ts › TuiRange › examples page › keyboard interactions › range with keySteps (from 0 to 1M) with 8 steps. Initial value [0, 100_000] › cannot set position of the RIGHT slider LESS THAN position of the LEFT slider (by ArrowDown)
webkit › tests/kit/slider/slider.pw.spec.ts › Slider › programmatically change value › ngModel › decrease value by 1 step
webkit › tests/kit/slider/slider.pw.spec.ts › Slider › programmatically change value › ngModel › increase value by 1 step
webkit › tests/kit/slider/slider.pw.spec.ts › Slider › programmatically change value › ngModel › increase value by 2 steps
webkit › tests/kit/tabs/tabs.pw.spec.ts › Tabs › Examples › complex › no extra margin after the last tab
webkit › tests/kit/tabs/tabs.pw.spec.ts › Tabs › Examples › complex › shows only a single dropdown for the nested item (with [tuiDropdown]) inside more section
webkit › tests/layout/navigation.pw.spec.ts › Navigation › Show settings in aside
webkit › tests/layout/navigation.pw.spec.ts › Navigation › Show hint in aside
webkit › tests/layout/navigation.pw.spec.ts › Navigation › A12y
webkit › tests/legacy/input-time/input-time.pw.spec.ts › InputTime › API › items are passed › the dropdown is visible when the input is focused
webkit › tests/legacy/input-time/input-time.pw.spec.ts › InputTime › API › items are passed › the dropdown is configured for s size
webkit › tests/legacy/input-time/input-time.pw.spec.ts › InputTime › API › items are passed › the dropdown is configured for m size
webkit › tests/legacy/input-time/input-time.pw.spec.ts › InputTime › API › items are passed › the dropdown is configured for l size

…d native back button

waterplea requested a review from a team as a code owner February 3, 2025 14:04

waterplea requested review from MarsiBarsi, nsbarsukov, vladimirpotekhin and mdlufy and removed request for a team February 3, 2025 14:04

github-actions bot assigned waterplea Feb 3, 2025

splincode approved these changes Feb 3, 2025

View reviewed changes

waterplea and others added 3 commits February 8, 2025 12:24

feat(core): Dialog/Dropdown use CloseWatcher to close on Androi…

24cea7c

…d native back button

chore: apply changes after linting [bot]

133bfa7

chore: fix

d56e4c0

waterplea force-pushed the close-watcher branch from c9438ff to d56e4c0 Compare February 8, 2025 08:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(core): `Dialog`/`Dropdown` use `CloseWatcher` to close on Android native back button #10300

feat(core): `Dialog`/`Dropdown` use `CloseWatcher` to close on Android native back button #10300

waterplea commented Feb 3, 2025

lumberjack-bot bot commented Feb 3, 2025 •

edited

Loading

github-actions bot commented Feb 3, 2025 •

edited

Loading

codecov bot commented Feb 3, 2025 •

edited

Loading

bundlemon bot commented Feb 3, 2025 •

edited

Loading

github-actions bot commented Feb 3, 2025

feat(core): Dialog/Dropdown use CloseWatcher to close on Android native back button #10300

Are you sure you want to change the base?

feat(core): Dialog/Dropdown use CloseWatcher to close on Android native back button #10300

Conversation

waterplea commented Feb 3, 2025

lumberjack-bot bot commented Feb 3, 2025 • edited Loading

Failed tests ❌

Before (main) ← Diff → After (local)

github-actions bot commented Feb 3, 2025 • edited Loading

codecov bot commented Feb 3, 2025 • edited Loading

Codecov Report

bundlemon bot commented Feb 3, 2025 • edited Loading

BundleMon

github-actions bot commented Feb 3, 2025

Playwright test results

Details

feat(core): `Dialog`/`Dropdown` use `CloseWatcher` to close on Android native back button #10300

feat(core): `Dialog`/`Dropdown` use `CloseWatcher` to close on Android native back button #10300

lumberjack-bot bot commented Feb 3, 2025 •

edited

Loading

github-actions bot commented Feb 3, 2025 •

edited

Loading

codecov bot commented Feb 3, 2025 •

edited

Loading

bundlemon bot commented Feb 3, 2025 •

edited

Loading