[WIP] feat(kit): `InputMonth` refactor to new `Textfield` #10345

nsbarsukov · 2025-02-11T13:36:42Z

@Component({
  standalone: true,
  imports: [
    TuiTextfield,
    TuiInputMonth,
  ],
})
export class Page {}

<tui-textfield
  tuiInputMonth
  [min]="min"
  [max]="max"
  [(ngModel)]="value"
>
  <input tuiTextfield />

  <tui-calendar-month
    *tuiTextfieldDropdown
    [disabledItemHandler]="disabledItemHandler"
    [(year)]="activeYear"
  />
</tui-textfield>

lumberjack-bot · 2025-02-11T13:36:48Z

Failed tests ❌

Before (main) ← Diff → After (local)

tests-demo-demo.pw-Demo-components-input-month-chromium-retry2/components-input-month/1.diff.png

tests-demo-demo.pw-Demo-components-input-month-webkit-retry2/components-input-month/1.diff.png

_{(updated for commit 7ad5aa7)}

github-actions · 2025-02-11T13:45:49Z

Visit the preview URL for this PR (updated for commit 7ad5aa7):

https://taiga-previews-demo--pr10345-new-input-month-demo-517o8laa.web.app

_{(expires Sat, 15 Feb 2025 15:26:50 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: 73dddc3c665194f3e11f18c16aeb71af4c289c37}

codecov · 2025-02-11T13:46:47Z

Codecov Report

Attention: Patch coverage is 43.01075% with 53 lines in your changes missing coverage. Please review.

Project coverage is 65.54%. Comparing base (106c961) to head (7ad5aa7).
Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
...it/components/input-month/input-month.directive.ts	26.92%	38 Missing ⚠️
...tive-month-picker/native-month-picker.component.ts	46.15%	7 Missing ⚠️
projects/kit/tokens/month-formatter.ts	50.00%	5 Missing ⚠️
...ectives/dropdown/dropdown-limit-width.directive.ts	33.33%	2 Missing ⚠️
.../kit/components/input-month/input-month.options.ts	75.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #10345      +/-   ##
==========================================
- Coverage   65.65%   65.54%   -0.11%     
==========================================
  Files        1246     1253       +7     
  Lines       16312    16408      +96     
  Branches     2343     2344       +1     
==========================================
+ Hits        10710    10755      +45     
- Misses       5386     5447      +61     
+ Partials      216      206      -10

Flag	Coverage Δ
summary	`65.54% <43.01%> (-0.11%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

bundlemon · 2025-02-11T14:20:13Z

BundleMon

Files updated (2)

Status	Path	Size	Limits
✅	demo/browser/main.(hash).js	311.34KB (+1.24KB +0.4%)	+10%
✅	demo/browser/runtime.(hash).js	47.1KB (+154B +0.32%)	+10%

Unchanged files (3)

Status	Path	Size	Limits
✅	demo/browser/vendor.(hash).js	260.29KB	+10%
✅	demo/browser/styles.(hash).css	20.93KB	+10%
✅	demo/browser/polyfills.(hash).js	11.18KB	+10%

Total files change +1.39KB +0.21%

Groups updated (1)

Status	Path	Size	Limits
✅	demo/browser/*..js	8.06MB (+53.6KB +0.65%)	-

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

github-actions · 2025-02-11T15:05:10Z

Playwright test results

10 failed
2077 passed
83 skipped

Details

Open report ↗︎
2170 tests across 73 suites
22 minutes, 17 seconds
19e6010

Failed tests

chromium › tests/deep/deep-select.pw.spec.ts › Deep / Select › /components/input-month
webkit › tests/deep/deep-select.pw.spec.ts › Deep / Select › /components/input-month
chromium › tests/deep/deep-toggle.pw.spec.ts › Deep / Toggle › /components/input-month
webkit › tests/deep/deep-toggle.pw.spec.ts › Deep / Toggle › /components/input-month
chromium › tests/demo/demo.pw.spec.ts › Demo › /components/input-month
webkit › tests/demo/demo.pw.spec.ts › Demo › /components/input-month
chromium › tests/legacy/input-month/input-month.pw.spec.ts › InputMonth › API › Maximum month less than current month
chromium › tests/legacy/input-month/input-month.pw.spec.ts › InputMonth › API › Minimum month more than current month
webkit › tests/legacy/input-month/input-month.pw.spec.ts › InputMonth › API › Maximum month less than current month
webkit › tests/legacy/input-month/input-month.pw.spec.ts › InputMonth › API › Minimum month more than current month

Skipped tests

webkit › tests/addon-commerce/input-card-group.pw.spec.ts › InputCardGroup › Examples › input card grouped with validation
webkit › tests/addon-commerce/input-card-group.pw.spec.ts › InputCardGroup › Examples › input card grouped with saved cards
webkit › tests/addon-commerce/input-card-group.pw.spec.ts › InputCardGroup › Examples › expired field should be clickable after reset of prefilled value
webkit › tests/addon-doc/navigation.pw.spec.ts › Navigation › anchor links navigation works › scroll to "tui-doc-example"
webkit › tests/addon-doc/navigation.pw.spec.ts › Navigation › anchor links navigation works › scroll to "tui-doc-code"
webkit › tests/addon-doc/navigation.pw.spec.ts › Navigation › anchor links navigation works › scroll after click on link with anchor
webkit › tests/addon-doc/navigation.pw.spec.ts › Navigation › getting started / [light mode]
webkit › tests/addon-doc/navigation.pw.spec.ts › Navigation › getting started / [dark mode]
webkit › tests/core/data-list/data-list.pw.spec.ts › DataList › Submenu
webkit › tests/core/data-list/data-list.pw.spec.ts › DataList › Form control
webkit › tests/core/data-list/data-list.pw.spec.ts › DataList › Complex
webkit › tests/core/data-list/data-list.pw.spec.ts › DataList › Options with long text
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 320x480 › Dialog with confirmation works › Prompt
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 320x480 › Dialog with confirmation works › Pristine form does not show confirmation
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 320x480 › Dialog with confirmation works › Dirty form shows confirmation
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 320x480 › Dialog with confirmation works › Form is reset to pristine
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 320x480 › A dialog and a nested dialog are open correctly
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 320x480 › Mobile dialog works
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 320x480 › Dialog with directive works
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 320x480 › Show simple
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 320x480 › Show simple + custom button
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 720x900 › Dialog with confirmation works › Prompt
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 720x900 › Dialog with confirmation works › Pristine form does not show confirmation
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 720x900 › Dialog with confirmation works › Dirty form shows confirmation
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 720x900 › Dialog with confirmation works › Form is reset to pristine
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 720x900 › A dialog and a nested dialog are open correctly
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 720x900 › Mobile dialog works
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 720x900 › Dialog with directive works
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 720x900 › Show simple
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 720x900 › Show simple + custom button
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 1024x900 › Dialog with confirmation works › Prompt
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 1024x900 › Dialog with confirmation works › Pristine form does not show confirmation
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 1024x900 › Dialog with confirmation works › Dirty form shows confirmation
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 1024x900 › Dialog with confirmation works › Form is reset to pristine
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 1024x900 › A dialog and a nested dialog are open correctly
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 1024x900 › Mobile dialog works
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 1024x900 › Dialog with directive works
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 1024x900 › Show simple
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 1024x900 › Show simple + custom button
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 1620x1024 › Dialog with confirmation works › Prompt
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 1620x1024 › Dialog with confirmation works › Pristine form does not show confirmation
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 1620x1024 › Dialog with confirmation works › Dirty form shows confirmation
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 1620x1024 › Dialog with confirmation works › Form is reset to pristine
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 1620x1024 › A dialog and a nested dialog are open correctly
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 1620x1024 › Mobile dialog works
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 1620x1024 › Dialog with directive works
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 1620x1024 › Show simple
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 1620x1024 › Show simple + custom button
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › Prompt - 320x480
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › Prompt - 720x900
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › Prompt - 1024x900
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › Prompt - 1620x1024
webkit › tests/core/surface/surface.pw.spec.ts › Surface › Layers
webkit › tests/kit/carousel/carousel.pw.spec.ts › Carousel › should show next item after drag
webkit › tests/kit/dropdown-hover/dropdown-hover.pw.spec.ts › DropdownHover › Examples › With DropdownMobile › Closes dropdown on click on overlay
webkit › tests/kit/dropdown-hover/dropdown-hover.pw.spec.ts › DropdownHover › Examples › With DropdownMobile › Opens mobile version of dropdown on the 2nd time click
webkit › tests/kit/input-number/input-number.pw.spec.ts › InputNumber › API › [prefix] & [postfix] props › [prefix]="$" & [postfix]="" › textfield does not contain any digit (only suffixes) => clear inputNumber.textfield value on blur
webkit › tests/kit/input-number/input-number.pw.spec.ts › InputNumber › API › [prefix] & [postfix] props › [prefix]="" & [postfix]="kg" › textfield does not contain any digit (only suffixes) => clear inputNumber.textfield value on blur
webkit › tests/kit/input-number/input-number.pw.spec.ts › InputNumber › API › [prefix] & [postfix] props › [prefix]="$" & [postfix]="kg" › textfield does not contain any digit (only suffixes) => clear inputNumber.textfield value on blur
webkit › tests/kit/range/range.pw.spec.ts › TuiRange › examples page › change selected range on click › click on the beginning of the track changes only nearest (left) slider
webkit › tests/kit/range/range.pw.spec.ts › TuiRange › examples page › change selected range on click › click on the end of the track changes only nearest (right) slider
webkit › tests/kit/range/range.pw.spec.ts › TuiRange › examples page › change selected range on click › click between two thumbs triggers only nearest thumb
webkit › tests/kit/range/range.pw.spec.ts › TuiRange › examples page › keyboard interactions › basic range (from 0 to 1000 with 250 steps). Initial value [0, 250] › pressing of Arrow Right increases by one step (after focus on right slider)
webkit › tests/kit/range/range.pw.spec.ts › TuiRange › examples page › keyboard interactions › basic range (from 0 to 1000 with 250 steps). Initial value [0, 250] › pressing of Arrow Right increases by one step (after focus on left slider)
webkit › tests/kit/range/range.pw.spec.ts › TuiRange › examples page › keyboard interactions › basic range (from 0 to 1000 with 250 steps). Initial value [0, 250] › pressing of Arrow Left decreases by one step (after setting right thumb active via click)
webkit › tests/kit/range/range.pw.spec.ts › TuiRange › examples page › keyboard interactions › basic range (from 0 to 1000 with 250 steps). Initial value [0, 250] › cannot set left thumb more than right thumb (by Arrow Right)
webkit › tests/kit/range/range.pw.spec.ts › TuiRange › examples page › keyboard interactions › basic range (from 0 to 1000 with 250 steps). Initial value [0, 250] › cannot set right thumb less than left thumb (by ArrowLeft)
webkit › tests/kit/range/range.pw.spec.ts › TuiRange › examples page › keyboard interactions › range with keySteps (from 0 to 1M) with 8 steps. Initial value [0, 100_000] › ArrowUp increases value of the focused slider
webkit › tests/kit/range/range.pw.spec.ts › TuiRange › examples page › keyboard interactions › range with keySteps (from 0 to 1M) with 8 steps. Initial value [0, 100_000] › ArrowDown decreases value of the focused slider
webkit › tests/kit/range/range.pw.spec.ts › TuiRange › examples page › keyboard interactions › range with keySteps (from 0 to 1M) with 8 steps. Initial value [0, 100_000] › cannot set position of the LEFT slider MORE THAN position of the RIGHT slider (by ArrowUp)
webkit › tests/kit/range/range.pw.spec.ts › TuiRange › examples page › keyboard interactions › range with keySteps (from 0 to 1M) with 8 steps. Initial value [0, 100_000] › cannot set position of the RIGHT slider LESS THAN position of the LEFT slider (by ArrowDown)
webkit › tests/kit/slider/slider.pw.spec.ts › Slider › programmatically change value › ngModel › decrease value by 1 step
webkit › tests/kit/slider/slider.pw.spec.ts › Slider › programmatically change value › ngModel › increase value by 1 step
webkit › tests/kit/slider/slider.pw.spec.ts › Slider › programmatically change value › ngModel › increase value by 2 steps
webkit › tests/kit/tabs/tabs.pw.spec.ts › Tabs › Examples › complex › no extra margin after the last tab
webkit › tests/kit/tabs/tabs.pw.spec.ts › Tabs › Examples › complex › shows only a single dropdown for the nested item (with [tuiDropdown]) inside more section
webkit › tests/layout/navigation.pw.spec.ts › Navigation › Show settings in aside
webkit › tests/layout/navigation.pw.spec.ts › Navigation › Show hint in aside
webkit › tests/layout/navigation.pw.spec.ts › Navigation › A12y
webkit › tests/legacy/input-time/input-time.pw.spec.ts › InputTime › API › items are passed › the dropdown is visible when the input is focused
webkit › tests/legacy/input-time/input-time.pw.spec.ts › InputTime › API › items are passed › the dropdown is configured for s size
webkit › tests/legacy/input-time/input-time.pw.spec.ts › InputTime › API › items are passed › the dropdown is configured for m size
webkit › tests/legacy/input-time/input-time.pw.spec.ts › InputTime › API › items are passed › the dropdown is configured for l size

nsbarsukov self-assigned this Feb 11, 2025

nsbarsukov changed the title ~~[WIP] feat(kit): InputMonth refactor to new Textfield~~ feat(kit): InputMonth refactor to new Textfield Feb 12, 2025

nsbarsukov marked this pull request as ready for review February 12, 2025 07:15

nsbarsukov requested a review from a team as a code owner February 12, 2025 07:15

nsbarsukov requested review from MarsiBarsi, waterplea, vladimirpotekhin and mdlufy and removed request for a team February 12, 2025 07:15

nsbarsukov changed the title ~~feat(kit): InputMonth refactor to new Textfield~~ [WIP] feat(kit): InputMonth refactor to new Textfield Feb 12, 2025

nsbarsukov force-pushed the new-input-month branch from 4d9f3b1 to 19e6010 Compare February 12, 2025 12:53

nsbarsukov added 2 commits February 14, 2025 14:07

feat(kit): InputMonth refactor to new Textfield

38da793

refactor: new approach tui-textfield[tuiInputMonth]

dcaa25e

nsbarsukov force-pushed the new-input-month branch from 19e6010 to dcaa25e Compare February 14, 2025 15:09

chore: apply changes after linting [bot]

7ad5aa7

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] feat(kit): `InputMonth` refactor to new `Textfield` #10345

[WIP] feat(kit): `InputMonth` refactor to new `Textfield` #10345

nsbarsukov commented Feb 11, 2025 •

edited

Loading

lumberjack-bot bot commented Feb 11, 2025 •

edited

Loading

github-actions bot commented Feb 11, 2025 •

edited

Loading

codecov bot commented Feb 11, 2025 •

edited

Loading

bundlemon bot commented Feb 11, 2025 •

edited

Loading

github-actions bot commented Feb 11, 2025 •

edited

Loading

[WIP] feat(kit): InputMonth refactor to new Textfield #10345

Are you sure you want to change the base?

[WIP] feat(kit): InputMonth refactor to new Textfield #10345

Conversation

nsbarsukov commented Feb 11, 2025 • edited Loading

lumberjack-bot bot commented Feb 11, 2025 • edited Loading

Failed tests ❌

Before (main) ← Diff → After (local)

github-actions bot commented Feb 11, 2025 • edited Loading

codecov bot commented Feb 11, 2025 • edited Loading

Codecov Report

bundlemon bot commented Feb 11, 2025 • edited Loading

BundleMon

github-actions bot commented Feb 11, 2025 • edited Loading

Playwright test results

Details

[WIP] feat(kit): `InputMonth` refactor to new `Textfield` #10345

[WIP] feat(kit): `InputMonth` refactor to new `Textfield` #10345

nsbarsukov commented Feb 11, 2025 •

edited

Loading

lumberjack-bot bot commented Feb 11, 2025 •

edited

Loading

github-actions bot commented Feb 11, 2025 •

edited

Loading

codecov bot commented Feb 11, 2025 •

edited

Loading

bundlemon bot commented Feb 11, 2025 •

edited

Loading

github-actions bot commented Feb 11, 2025 •

edited

Loading