[tailscale] runtime/debug: embed Tailscale toolchain git rev #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bradfitz
force-pushed
the
bradfitz/embed_git_rev
branch
from
95b3e02
to
d035b5e
Compare
bradfitz
force-pushed
the
bradfitz/embed_git_rev
branch
2 times, most recently
from
4a66346
to
503e192
Compare
raggi
approved these changes
Sep 19, 2024
This is another take on #49 (which we stopped using?), and less intrusive, and also always on. This puts puts the the Tailscale Go toolchain's git rev in the binary, accessible as a new "tailscale.toolchain.rev" runtime/debug.BuildInfo Setting. Caller code will have to access it guarded by the "tailscale_go" build tag. Updates #49 Signed-off-by: Brad Fitzpatrick <[email protected]>
bradfitz
force-pushed
the
bradfitz/embed_git_rev
branch
from
503e192
to
83c0ccb
Compare
bradfitz
added a commit
to tailscale/tailscale
that referenced
this pull request
Sep 20, 2024
Update go.toolchain.rev for tailscale/go#104 and add a test that, when using the tailscale_go build tag, we use the right Go toolchain. We'll crank up the strictness in later commits. Updates #13527 Change-Id: Ifb09a844858be2beb144a420e4e9dbdc5c03ae3a Signed-off-by: Brad Fitzpatrick <[email protected]>
bradfitz
added a commit
to tailscale/tailscale
that referenced
this pull request
Sep 20, 2024
Update go.toolchain.rev for tailscale/go#104 and add a test that, when using the tailscale_go build tag, we use the right Go toolchain. We'll crank up the strictness in later commits. Updates #13527 Change-Id: Ifb09a844858be2beb144a420e4e9dbdc5c03ae3a Signed-off-by: Brad Fitzpatrick <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another take on #49 (which we stopped using?), and less
intrusive, and also always on.
This puts puts the the Tailscale Go toolchain's git rev in
the binary, accessible as runtime/debug.TailscaleGitRev.
Caller code will have to access it guarded by the "tailscale_go" build
tag.
Updates #49