Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

android: Scan QR code to sign in #507

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

android: Scan QR code to sign in #507

wants to merge 1 commit into from

Conversation

joshvocal
Copy link
Contributor

@joshvocal joshvocal commented Sep 14, 2024 •
edited
Loading

Resolves: tailscale/tailscale#13377

QR Code Log In Flow

Screen.Recording.2024-09-14.at.3.15.54.PM.mp4

Camera Permissions

Screen.Recording.2024-09-14.at.3.21.40.PM.mp4

Steps to test:

  1. Use another device that can display a QR code to sign-in. (Ex: tailscale login --qr)
  2. Go to the log-in screen on Android
  3. Click "Scan QR code" > Scan the QR code
  4. Sign into the browser when prompted
  5. Observe the displayed QR code in the CLI for "Success"

Expected results:

  • Proper camera permissions are displayed when you allow/deny camera permissions
  • Scanning the QR code works to sign in.

@joshvocal
android: Scan QR code to sign in
5395e7e 
Fixes: tailscale/tailscale#13377

* Uses ML Kit on Android to scan QR codes to launch a browser
to sign in

Signed-off-by: Josh Vocal <[email protected]>
@joshvocal joshvocal marked this pull request as ready for review September 14, 2024 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Android devices should scan a QR code to log in
1 participant
@joshvocal