android: send Android logs to logz #515
Conversation
|
Can we rename ExtendedLog to TSLog or TsLog? It is less stuff to type, and would match what we use in Swift :) |
kari-ts
force-pushed
the
kari/androidlog
branch
2 times, most recently
from
8040c04
to
95ce37f
Compare
| @@ -59,7 +60,7 @@ object Notifier { | |||
|
|
|||
| @OptIn(ExperimentalSerializationApi::class) | |||
| fun start(scope: CoroutineScope) { | |||
| Log.d(TAG, "Starting") | |||
| TSLog.d(TAG, "Starting") | |||
There was a problem hiding this comment.
| TSLog.d(TAG, "Starting") | |
| TSLog.d(TAG, "Starting Notifier") |
| @@ -89,7 +90,7 @@ object Notifier { | |||
| } | |||
|
|
|||
| fun stop() { | |||
| Log.d(TAG, "Stopping") | |||
| TSLog.d(TAG, "Stopping") | |||
There was a problem hiding this comment.
| TSLog.d(TAG, "Stopping") | |
| TSLog.d(TAG, "Stopping Notifier") |
| import libtailscale.Libtailscale | ||
|
|
||
| object TSLog { | ||
| var libtailscaleWrapper = LibtailscaleWrapper() |
There was a problem hiding this comment.
this can't be private because we use it in TimeUtilTest
| import android.util.Log | ||
| import libtailscale.Libtailscale | ||
|
|
||
| object TSLog { |
There was a problem hiding this comment.
Let's document why this exists and when it should be used in place of the util.Log.
libtailscale/interfaces.go
Outdated
| @@ -169,3 +171,13 @@ func RequestVPN(service IPNService) { | |||
| func ServiceDisconnect(service IPNService) { | |||
| onDisconnect <- service | |||
| } | |||
|
|
|||
| func SendLog(logstr string) { | |||
There was a problem hiding this comment.
Would it be more efficient to use a []byte or byteArray here similar to what we did going the other way for localAPI? That might avoid a bunch of object copies.
There was a problem hiding this comment.
very good idea. done.
| Log.e(tag, message, throwable) | ||
| libtailscaleWrapper.sendLog(tag, "$message ${throwable?.localizedMessage}") | ||
| } | ||
| } |
There was a problem hiding this comment.
In swift, we have the notion of debug logs (which only show up when you do local debug builds) and verbose logs, which sit behind a flag you can toggle at build or runtime.
There was a problem hiding this comment.
oh nice, this is a good idea. I think we can use Proguard to strip out logs for release builds, so maybe we could use that to strip verbose/debug logs? or we can specify in build flavors in our build.gradle. I'll do this in a follow up
TSLog sends log messages to Android's logcat and Tailscale's logger Libtailscale wrapper is a Kotlin wrapper that allows us to get around the problems with mocking a native library Fixes tailscale/corp#23191 Signed-off-by: kari-ts <[email protected]>
kari-ts
force-pushed
the
kari/androidlog
branch
from
95ce37f
to
441f29f
Compare
ExtendedLog sends log messages to Android's logcat and Tailscale's logger Libtailscale wrapper is a Kotlin wrapper that allows us to get around the problems with mocking a native library
Fixes tailscale/corp#23191