Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix formatting issue #1462

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix formatting issue #1462

wants to merge 1 commit into from

Conversation

mi-hol
Copy link
Contributor

@mi-hol mi-hol commented Feb 11, 2025

image

was not showing in TOC

@mi-hol
Copy link
Contributor Author

mi-hol commented Feb 19, 2025

@blakadder @arendst @gemu2015
I've started to work on improvements of documentation for scripting language with support from gemu2015.
Unfortunately progress is slow due to PR like this one not getting merged quickly.
Would there be a chance for me to become a document maintainer (as I am in other projects) to accelerate progress?

@blakadder
Copy link
Contributor

How exactly does this PR impede your progress?

If you're developing significant changes fork it and work on your own repo until it's finished.

@mi-hol
Copy link
Contributor Author

mi-hol commented Feb 19, 2025

only "forking" will not allow to produce the desired result, because the doc website is "Built on MkDocs using Material for MkDocs theme." but for this build process, no simple and clear instructions are visible in the ReadMe.
This is the hurdle to overcome for finishing changes in a fork , at this stage I don't know how to!
It is exactly this hurdle that impedes my progress.

@blakadder
Copy link
Contributor

You install mkdocs with the requirements on your computer and build it locally. That's what the github workflow does and then simply deploys it in the pages branch to serve

@mi-hol
Copy link
Contributor Author

mi-hol commented Feb 19, 2025

You install mkdocs with the requirements on your computer

will try, but how about merging this PR now?

@blakadder
Copy link
Contributor

It will be merged pending review

@mi-hol
Copy link
Contributor Author

mi-hol commented Feb 19, 2025

there are PRs pending for over one year without a single comment!

What message does this relay to the community of engaged contributors?

@blakadder
Copy link
Contributor

It relays that time is precious and it's currenty being wasted on trivialities instead of being used to review PRs

@mi-hol
Copy link
Contributor Author

mi-hol commented Feb 19, 2025

my take on this is quite different

@mi-hol
Copy link
Contributor Author

mi-hol commented Feb 19, 2025

@arendst my offer stands to improve the collaboration with contributors to improved Tasmota's documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants