Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new Solid.js example #2144

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Add new Solid.js example #2144

wants to merge 15 commits into from

Conversation

BasixKOR
Copy link

@BasixKOR BasixKOR commented May 16, 2021

  • Please use squash merge.

Hi, I created TodoMVC with Solid.js and I think it's worth sharing with y'all, so I'm proposing this to as a new app example.

image

It passes all the tests as you can see above.

Reason to propose the TodoMVC in Solid.js

Notes

  • Since JSHint doesn't seems to support latest JavaScript features such as JSX and modules, it was hard to match code styles using JSHint.
  • I bulit up custom Rollup config to work nicely with current infra. Probably a lot of space for improvement.
  • This example requires an build step (which is just a single rollup run). If you prefer we can track the bundle on GitHub so users can skip the build.

@@ -0,0 +1,31 @@
import { Switch, useContext } from "solid-js";

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Import For?

@@ -0,0 +1,34 @@
import { For, Show, useContext } from 'solid-js';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For is not being used

@@ -0,0 +1,46 @@
import { createEffect, createSignal, useContext } from "solid-js";

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

createEffect not being used

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants